Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always build in debug mode with sanitizers + increase compiler warning levels #169

Open
superwhiskers opened this issue Jun 20, 2024 · 0 comments
Assignees
Labels
cmake enhancement New feature or request

Comments

@superwhiskers
Copy link
Collaborator

superwhiskers commented Jun 20, 2024

currently, the usage of address sanitizer is gated behind RESOLVE_USE_ASAN. as suggested in another pull request i propose we:

  • increase the number of sanitizers we enable to those enabled by -fsanitize=address,undefined,integer to check for undefined behavior and integer overflow, in addition to the memory safety problems checked by address sanitizer
  • enable these sanitizers in automated tests (such as those being added by Add ctest to spack build pipelines. #118) and when building in debug mode (-DCMAKE_BUILD_TYPE=Debug)

additionally, i propose we increase the warnings reported by the compiler by passing -Wall -Wpedantic -Wconversion -Wextra to CFLAGS/CXXFLAGS in all build types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants