Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using smart pointers in ReSolve #88

Open
pelesh opened this issue Nov 29, 2023 · 2 comments
Open

Consider using smart pointers in ReSolve #88

pelesh opened this issue Nov 29, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@pelesh
Copy link
Collaborator

pelesh commented Nov 29, 2023

Based on @cameronrutherford comment: This is endemic to ExaGO and HiOp, but I would be curious if we could get away from managing raw pointers like this, and have more of our examples use more modern C++ resource management techniques with shared/unique pointers where absolutely necessary, and then just having non-pointer variables here that are cleaned up without delete.

Originally posted by @cameronrutherford in #83 (comment)

@cameronrutherford
Copy link
Collaborator

I take this as you agree with my suggestion, but this change will require a little bit of work :)

@pelesh pelesh self-assigned this Nov 29, 2023
@pelesh pelesh added the enhancement New feature or request label Nov 29, 2023
@pelesh
Copy link
Collaborator Author

pelesh commented Nov 29, 2023

I take this as you agree with my suggestion, but this change will require a little bit of work :)

We can do it in incremental steps. For vector/matrix data I think we need to keep raw pointers for portability. But for objects such as Gram-Schmidt, it would make more sense to use smart pointers.

CC @kswirydo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants