Revert "Changes default return value for cluster.batch_connect_ssh_al… (

#820)

* Revert "Changes default return value for cluster.batch_connect_ssh_allow? (#818)"

This reverts commit 6504b5f.

* Updates changelog & version for next release

CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+## [0.24.1] - 11-29-2023
+
+[820](https://github.com/OSC/ood_core/pull/820) Reverts [818](https://github.com/OSC/ood_core/pull/818)
+
 ## [0.24.0] - 11-28-2023
 
 - Code cleanup and separate arguments with whitespace in Fujitsu TCS adapter by @mnakao in https://github.com/OSC/ood_core/pull/808

lib/ood_core/cluster.rb

@@ -165,9 +165,9 @@ def allow?
     # @return [Boolean, nil] whether cluster supports SSH to batch connect node
     def batch_connect_ssh_allow?
       return @batch_connect_ssh_allow if defined?(@batch_connect_ssh_allow)
-      return @batch_connect_ssh_allow = true if batch_connect_config.nil?
+      return @batch_connect_ssh_allow = nil if batch_connect_config.nil?
 
-      @batch_connect_ssh_allow = batch_connect_config.fetch(:ssh_allow, true)
+      @batch_connect_ssh_allow = batch_connect_config.fetch(:ssh_allow, nil)
     end
 
     # The comparison operator

lib/ood_core/version.rb

@@ -1,4 +1,4 @@
 module OodCore
   # The current version of {OodCore}
-  VERSION = "0.24.0"
+  VERSION = "0.24.1"
 end

spec/cluster_spec.rb

@@ -53,7 +53,7 @@
       end
 
       it 'has default for batch_connect_ssh_allow?' do
-        expect(owens.batch_connect_ssh_allow?).to be true
+        expect(owens.batch_connect_ssh_allow?).to be_nil
       end
 
       it 'can enable batch_connect_ssh_allow?' do