Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor helper from class to module #786

Open
johrstrom opened this issue Jan 5, 2023 · 0 comments
Open

refactor helper from class to module #786

johrstrom opened this issue Jan 5, 2023 · 0 comments

Comments

@johrstrom
Copy link
Contributor

johrstrom commented Jan 5, 2023

This helper class is used in basically every adapter.
https://github.com/OSC/ood_core/blob/master/lib/ood_core/job/adapters/helper.rb

Instead of having a class that you reference, instead we should just have it as a module that is included in the Adapter parent class so that all adapters just have these helper methods available and don't have to go about referencing the static OodCore::Job::Adapters::Helper class.

┆Issue is synchronized with this Asana task by Unito

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant