-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for mellon auth #135
base: master
Are you sure you want to change the base?
Conversation
@treydock I've been using this in prod for well over an year, finally got around to push it upstream. |
@@ -0,0 +1,22 @@ | |||
#!/usr/bin/env bash | |||
|
|||
MELLON_DIR="<%= scope['apache::params::httpd_dir'] -%>/mellon" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MELLON_DIR="<%= scope['apache::params::httpd_dir'] -%>/mellon" | |
MELLON_DIR="<%= scope['apache::httpd_dir'] -%>/mellon" |
Ensure use correct value is someone overrides
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the defaults seem to have hardcoded paths while here it's based on Apache data. I think it would be best to define something like openondemand::mellon_dir
and make that used as base directory for all these files and paths.
@bp85 Generally I don't recommend deploying things that require manual steps, that somewhat defeats the purpose of Puppet. I think one way to achieve full automation is this:
|
I also see some hardcoded paths for Mellon defaults while other places use variables from Apache module. I think all paths should be defined in init.pp , and referenced downstream in various places using maybe the |
proxy_server
configuration option forood_portal.yml