Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IEC61850 client port not configurable #250

Open
ThE-MaRaC opened this issue Apr 28, 2021 · 3 comments
Open

IEC61850 client port not configurable #250

ThE-MaRaC opened this issue Apr 28, 2021 · 3 comments

Comments

@ThE-MaRaC
Copy link

In the osgp-adapter-protocol-iec61850.properties there is a property for client port configuration. Default value is:
iec61850.port.client=102
But, this value is never used, instead, a hardcoded value from Iec61850DeviceConnectionService.java is used.
private static final int IEC61850_DEFAULT_PORT = 102;
Please let me know if I should provide a pull request with the correction.

@kevinsmeets
Copy link
Contributor

Hello @ThE-MaRaC , the port for IEC61850 devices can be configured using database records. I think this code may be conflicting with the global property your mention. It would be great if you are willing to create a fix for this situation :)

@ThE-MaRaC
Copy link
Author

Sure, I will provide a pull request with the correction.

ThE-MaRaC pushed a commit to ThE-MaRaC/open-smart-grid-platform that referenced this issue Jul 9, 2021
@smvdheijden
Copy link
Member

The codebase seems to have changed (The hardcoded value is no longer present) .
Could you please verify if this issue is still valid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants