Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ckpt in HuggingFace #22

Open
mo230761 opened this issue Oct 26, 2024 · 8 comments
Open

ckpt in HuggingFace #22

mo230761 opened this issue Oct 26, 2024 · 8 comments

Comments

@mo230761
Copy link

I really like your work! But I found that the results using the HuggingFace version are not as good as when using the source code. Upon further exploration, I discovered that the HuggingFace version might not be using EMA. Is that the case? If so, how can I use the EMA version of the checkpoint with HuggingFace?

@drogozhang
Copy link
Member

We were using EMA. Please see fine-tune.yaml

@mo230761
Copy link
Author

Thank you for answering my questions!! I would like to know how you convert a ckpt file into a format that can be used by Hugging Face.

@drogozhang
Copy link
Member

That's actually a very good question haha. Amazing @vinesmsuic helped deploy it so I don't really know. Maybe @vinesmsuic can point us to somewhere?

@mo230761
Copy link
Author

Thank you again for your answer!!! And I would like to ask if @vinesmsuic could provide some guidance? If possible, I would be extremely grateful.

@vinesmsuic
Copy link

Hi @mo230761 , I don't exactly remembered how did I convert the weights back then since it has been a while. It could be possible that I missed the EMA option. But IIRC diffusers port are performing a bit worse, even for InstructPix2Pix.

Would you mind helping me to test the performance of this?
https://huggingface.co/vinesmsuic/magicbrush-ema

@mo230761
Copy link
Author

mo230761 commented Nov 1, 2024

Of course! I’ve also run some data using the EMA version you provided. Its results are indeed slightly worse than the original, but it’s better than the previous ported version that didn’t use EMA. It’s a pity that you don’t exactly remember how you converted the weights back then.

@vinesmsuic
Copy link

vinesmsuic commented Nov 1, 2024

@mo230761
it would be great if you can share some visualizations.

@mo230761
Copy link
Author

mo230761 commented Nov 2, 2024

This might not be possible, as the data I’m testing is under a confidentiality agreement. My apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants