-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map vs Building name discrepancy #271
Comments
Code Reference LogsBuilding off of the above code, all
|
Map page (https://dashboard.sustainability.oregonstate.edu/#/map) and Building List Page (https://dashboard.sustainability.oregonstate.edu/#/buildings) have slightly different names for buildings (e.g. Arnold Cafeteria on Map vs Arnold Dining Hall on Building List page).
This is because Building list calls a VueX frontend state function, while Map calls Openstreet API for building names.
It's a good idea to consolidate this, especially if we may be adding buildings in future that aren't in OpenStreet. Right now we're hard coding OSU Operations building name into our frontend code, for Map.
Map relevant code
https://github.com/OSU-Sustainability-Office/energy-dashboard/blob/master/src/components/map/map.vue#L209
Building list relevant code
https://github.com/OSU-Sustainability-Office/energy-dashboard/blob/master/src/components/building_list/building_list.vue#L94
Openstreetmap
https://www.openstreetmap.org
https://github.com/OSU-Sustainability-Office/energy-dashboard/blob/master/src/store/api.js#L70C10-L70C53
https://wiki.openstreetmap.org/wiki/Planet.osm
VueX
SQL Database
Buildings Table (just for reference, use the equivalent
this.$store.getters['map/buildings']
when coding)SELECT * from buildings
Code Reference logs
src\components\map\map.vue
line 207 ishlayer.on( 'mouseover', function ( e ) {
tolayer.on( 'mouseover', e => {
, fixed not being able to accessthis
variables in this sectionlayer.on( 'click', e => {
a few lines up inmap.vue
file. Should be a harmless change, but watch for any bugs or performance issuessrc\components\building_list\building_list.vue
line 94 ishThe text was updated successfully, but these errors were encountered: