Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 [Refactor] Backend: Metascraper Language Detection #8059

Open
mahula opened this issue Oct 30, 2024 · 0 comments
Open

🔧 [Refactor] Backend: Metascraper Language Detection #8059

mahula opened this issue Oct 30, 2024 · 0 comments

Comments

@mahula
Copy link
Contributor

mahula commented Oct 30, 2024

Motivation

The current Dependabot Metascraper Bump PR revealed, that the package metascraper-lang-detector we initialy utilized, does not exist in Metascraper v5 anymore.
There are no informations on Metascraper side, when and how it has been deprecated and how to migtrate to utilize only their package metascraper-lang to handlelanguage detection as we implemented it (see https://github.com/search?q=repo%3Amicrolinkhq%2Fmetascraper%20metascraper-lang-detector&type=code, https://github.com/microlinkhq/metascraper/tree/HEAD/packages/metascraper-lang, https://metascraper.js.org/)

TODO

We should check whether our Metascraper language detection implementation still works as intended and adapt it to the currently offered approach if necessary.

If the offered approach does not work for us at the moment, we could roll back the metascraper packages to the latest 4.x version (as in the last deployments for the actively running network instances).

Related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

1 participant