Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return sticker URL with sticker comments #90

Open
tzarebczan opened this issue Oct 22, 2021 · 3 comments
Open

return sticker URL with sticker comments #90

tzarebczan opened this issue Oct 22, 2021 · 3 comments

Comments

@tzarebczan
Copy link
Contributor

Should the app just add these, or should we keep the comment clean + return as part of a comment property?

const CAT_BORDER = 'https://static.odycdn.com/stickers/CAT/PNG/cat_with_border.png';
const FAIL_BORDER = 'https://static.odycdn.com/stickers/FAIL/PNG/fail_with_border.png';
const HYPE_BORDER = 'https://static.odycdn.com/stickers/HYPE/PNG/hype_with_border.png';
const PANTS_1_WITH_FRAME = 'https://static.odycdn.com/stickers/PANTS/PNG/PANTS_1_with_frame.png';
const PANTS_2_WITH_FRAME = 'https://static.odycdn.com/stickers/PANTS/PNG/PANTS_2_with_frame.png';
const PISS = 'https://static.odycdn.com/stickers/PISS/PNG/piss_with_frame.png';
const PREGNANT_MAN_ASIA_WHITE_BORDER =
  'https://static.odycdn.com/stickers/pregnant man/png/Pregnant man_white border_asia.png';
const PREGNANT_MAN_BLACK_HAIR_WHITE_BORDER =
  'https://static.odycdn.com/stickers/pregnant man/png/Pregnant man_white border_black hair.png';
const PREGNANT_MAN_BLACK_SKIN_WHITE_BORDER =
  'https://static.odycdn.com/stickers/pregnant man/png/Pregnant man_white border_black skin.png';
const PREGNANT_MAN_BLONDE_WHITE_BORDER =
  'https://static.odycdn.com/stickers/pregnant man/png/Pregnant man_white border_blondie.png';
const PREGNANT_MAN_RED_HAIR_WHITE_BORDER =
  'https://static.odycdn.com/stickers/pregnant man/png/Pregnant man_white border_red hair                  .png';
const PREGNANT_WOMAN_BLACK_HAIR_GREEN_SHIRT_WHITE_BORDER =
  'https://static.odycdn.com/stickers/pregnant woman/png/Pregnant woman_white_border_black hair green shirt.png';
const PREGNANT_WOMAN_BLACK_HAIR_WHITE_BORDER =
  'https://static.odycdn.com/stickers/pregnant woman/png/Pregnant woman_white_border_black hair.png';
const PREGNANT_WOMAN_BLACK_SKIN_WHITE_BORDER =
  'https://static.odycdn.com/stickers/pregnant woman/png/Pregnant woman_white_border_black woman.png';
const PREGNANT_WOMAN_BLONDE_WHITE_BORDER =
  'https://static.odycdn.com/stickers/pregnant woman/png/Pregnant woman_white_border_blondie.png';
const PREGNANT_WOMAN_BROWN_HAIR_WHITE_BORDER =
  'https://static.odycdn.com/stickers/pregnant woman/png/Pregnant woman_white_border_brown hair.png';
const PREGNANT_WOMAN_RED_HAIR_WHITE_BORDER =
  'https://static.odycdn.com/stickers/pregnant woman/png/Pregnant woman_white_border_red hair                  .png';
const ROCKET_SPACEMAN_WITH_BORDER =
  'https://static.odycdn.com/stickers/ROCKET SPACEMAN/PNG/rocket-spaceman_with-border.png';
const SALTY = 'https://static.odycdn.com/stickers/SALTY/PNG/salty.png';
const SICK_2_WITH_BORDER = 'https://static.odycdn.com/stickers/SICK/PNG/sick2_with_border.png';
const SICK_1_WITH_BORDERDARK_WITH_FRAME = 'https://static.odycdn.com/stickers/SICK/PNG/with borderdark with frame.png';
const SLIME_WITH_FRAME = 'https://static.odycdn.com/stickers/SLIME/PNG/slime_with_frame.png';
const SPHAGETTI_BATH_WITH_FRAME = 'https://static.odycdn.com/stickers/SPHAGETTI BATH/PNG/sphagetti bath_with_frame.png';
const THUG_LIFE_WITH_BORDER = 'https://static.odycdn.com/stickers/THUG LIFE/PNG/thug_life_with_border_clean.png';
const WHUUT_WITH_FRAME = 'https://static.odycdn.com/stickers/WHUUT/PNG/whuut_with-frame.png';
const COMET_TIP = 'https://static.odycdn.com/stickers/TIPS/png/$ comet tip with border.png';
const BIG_LBC_TIP = 'https://static.odycdn.com/stickers/TIPS/png/big_LBC_TIPV.png';
const BIG_TIP = 'https://static.odycdn.com/stickers/TIPS/png/with borderbig$tip.png';
const BITE_TIP = 'https://static.odycdn.com/stickers/TIPS/png/bite_$tip_with border.png';
const BITE_TIP_CLOSEUP = 'https://static.odycdn.com/stickers/TIPS/png/bite_$tip_closeup.png';
const FORTUNE_CHEST_LBC = 'https://static.odycdn.com/stickers/TIPS/png/with borderfortunechest_LBC_tip.png';
const FORTUNE_CHEST = 'https://static.odycdn.com/stickers/TIPS/png/with borderfortunechest$_tip.png';
const LARGE_LBC_TIP = 'https://static.odycdn.com/stickers/TIPS/png/with borderlarge_LBC_tip .png';
const LARGE_TIP = 'https://static.odycdn.com/stickers/TIPS/png/with borderlarge$tip.png';
const BITE_LBC_CLOSEUP = 'https://static.odycdn.com/stickers/TIPS/png/LBC bite.png';
const LBC_COMET_TIP = 'https://static.odycdn.com/stickers/TIPS/png/LBC comet tip with border.png';
const MEDIUM_LBC_TIP = 'https://static.odycdn.com/stickers/TIPS/png/with bordermedium_LBC_tip          .png';
const MEDIUM_TIP = 'https://static.odycdn.com/stickers/TIPS/png/with bordermedium$_ tip.png';
const SILVER_ODYSEE_COIN = 'https://static.odycdn.com/stickers/TIPS/png/with bordersilver_odysee_coinv.png';
const SMALL_LBC_TIP = 'https://static.odycdn.com/stickers/TIPS/png/with bordersmall_LBC_tip .png';
const SMALL_TIP = 'https://static.odycdn.com/stickers/TIPS/png/with bordersmall$_tip.png';
const TIP_HAND_FLIP = 'https://static.odycdn.com/stickers/TIPS/png/tip_hand_flip_$ _with_border.png';
const TIP_HAND_FLIP_COIN = 'https://static.odycdn.com/stickers/TIPS/png/tip_hand_flip_coin_with_border.png';
const TIP_HAND_FLIP_LBC = 'https://static.odycdn.com/stickers/TIPS/png/tip_hand_flip_lbc_with_border.png';
@tiger5226
Copy link
Collaborator

I think they are constants and it doesn't much matter where they are outside of bandwidth to send the additional text for the countless calls. If its client side its on the client when it downloads things. I think there is an argument for keeping this text out of the app files for faster UI loading too. But sending the text repeatedly costs time too as opposed to loading the urls once as consts.

@tzarebczan
Copy link
Contributor Author

Other tools like overlays will want to integrate these. So maybe we'd add an api to return the list instead. Could probably be done on the app side, but more comment related.

@kauffj
Copy link

kauffj commented Jan 3, 2022

Use LBRY to store the stickers :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants