Serve missing internal files as 404 instead of soft-404 page #2983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Issue Requesting for an invalid js file like `https://odysee.com/public/some-non-existent-file.js` yields HTML, which is usually incorrectly redirect to an actual claim, or a soft-404 page. It's not only showing incorrectly data, but it is being cached. This is one of the potential causes for the problem of users being stuck with bad cache. ## Approach - In the final catch-all stage, try to detect if it's a file request, and return a 404 instead. - Do no cache 404s. Same as https://community.cloudflare.com/t/404s-and-caching/337151. The file could eventually be corrected, but users remain stuck with 404. ## Concerns - Is the detection too loose?
|
This is a good approach, thank you! Should help with future edge issues potentially too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the deeper root-cause for the ChunkLoadError.
Issue
Requesting for an missing/invalid js file like
https://odysee.com/public/some-non-existent-file.jsyields HTML, which is usually incorrectly redirected to an actual claim, or the React soft-404 page.Besides incorrect, it is also being cached. Users are stuck until cache is manually cleared.
Approach
Warning
Is the detection too loose? Any better ideas to not over-catch?