Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab Removal button still gets enabled after 5secs even the setValidityState is false #2363

Open
aniketrai opened this issue Jun 18, 2024 · 4 comments
Assignees
Labels
teams issue issue that has been reviewed and likely teams specific teams-developer-support

Comments

@aniketrai
Copy link

Context - Removing a tab (Configurable Tab)

The text was removed which says that Remove button will be enabled after 5 secs. Does this mean this feature is implemented?

If so, I am still facing the issue. I am making the button disable by pages.config.setValidityState(false); but still it gets enabled after 5 secs.

Commit - MicrosoftDocs/msteams-docs#10538

Expected - If using pages.config.setValidityState(false); the remove button should not be enabled.

Actual - Remove button is still getting enabled after 5 secs

@TrevorJoelHarris TrevorJoelHarris added the teams issue issue that has been reviewed and likely teams specific label Jun 18, 2024
@Meghana-MSFT
Copy link

Thank you for reporting this, we will check this and get back to you.

@aniketrai
Copy link
Author

Any update?

@aniketrai
Copy link
Author

Hi @Meghana-MSFT, can you please update. This we need it urgently. We are about to rollout our app to customers.

@Meghana-MSFT
Copy link

Meghana-MSFT commented Jun 24, 2024

@aniketrai - We are checking this internally; we will get back to you.

Update : Engineering team has confirmed that this behavior is by design. We intentionally light up the "Remove" button after 5 seconds because we do not want users to ever lose the ability to remove a tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
teams issue issue that has been reviewed and likely teams specific teams-developer-support
Projects
None yet
Development

No branches or pull requests

4 participants