Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSO quick start has confusing unnecessary sideloading step #4688

Open
Rick-Kirkham opened this issue Jul 25, 2024 · 3 comments
Open

SSO quick start has confusing unnecessary sideloading step #4688

Rick-Kirkham opened this issue Jul 25, 2024 · 3 comments
Assignees
Labels
Area: authentication Feedback on authentication content Needs: attention 👋 Waiting on Microsoft to provide feedback Type: doc bug Problem with the documentation (e.g., doc is out of date, unclear, confusing, or broken)

Comments

@Rick-Kirkham
Copy link
Contributor

Rick-Kirkham commented Jul 25, 2024

In SSO quick start

The Outlook subheading of the Test your add-in header:
Step 1 has the user run npm start.
Step 2 tells the user to go to another article and sideload the add-in. This is not necessary. The npm start command sideloads the add-in.

image

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: triage 🔍 New issue, needs PM on rotation to triage ASAP label Jul 25, 2024
@Rick-Kirkham Rick-Kirkham added Area: authentication Feedback on authentication content Type: doc bug Problem with the documentation (e.g., doc is out of date, unclear, confusing, or broken) Needs: attention 👋 Waiting on Microsoft to provide feedback and removed Needs: triage 🔍 New issue, needs PM on rotation to triage ASAP labels Jul 25, 2024
@AlexJerabek
Copy link
Collaborator

@Rick-Kirkham,

I just tried running this quick start with the unified manifest. Running npm start produced the following errors:

--Error sideloading!--
Error: Error: Command failed: npx @microsoft/teamsapp-cli install --file-path "C:\Users\aljerabe\AppData\Local\Temp\manifest.zip"
(×) Error: M365.PackageServiceError: Request failed with status code 400 (tracingId: 00-9e85307771ef5a9990285633fb1ac6ea-16ea057f657f02c1-01) BadRequest: Manifest is not valid: [
  "String '{application GUID here}' does not match regex pattern '^[0-9a-fA-F]{8}-([0-9a-fA-F]{4}-){3}[0-9a-fA-F]{12}$'. Path 'webApplicationInfo.id', line 40, position 39."
]

STDERR:
(×) Error: M365.PackageServiceError: Request failed with status code 400 (tracingId: 00-9e85307771ef5a9990285633fb1ac6ea-16ea057f657f02c1-01) BadRequest: Manifest is not valid: [
  "String '{application GUID here}' does not match regex pattern '^[0-9a-fA-F]{8}-([0-9a-fA-F]{4}-){3}[0-9a-fA-F]{12}$'. Path 'webApplicationInfo.id', line 40, position 39."
]

Error: Unable to start debugging.
Error: Unable to sideload the Office Add-in.
Error: Command failed: npx @microsoft/teamsapp-cli install --file-path "C:\Users\aljerabe\AppData\Local\Temp\manifest.zip"
(×) Error: M365.PackageServiceError: Request failed with status code 400 (tracingId: 00-9e85307771ef5a9990285633fb1ac6ea-16ea057f657f02c1-01) BadRequest: Manifest is not valid: [
  "String '{application GUID here}' does not match regex pattern '^[0-9a-fA-F]{8}-([0-9a-fA-F]{4}-){3}[0-9a-fA-F]{12}$'. Path 'webApplicationInfo.id', line 40, position 39."
]

@Rick-Kirkham
Copy link
Contributor Author

@AlexJerabek That's a side effect of one of the problems I've always had with the SSO templates and why I questioned a few months ago whether we should keep them. The generated project can't really be used unless the developer is working through the SSO quick start. In that quick start they find out that there is a step you have to take before you run npm start: you have to run npm run configure-sso first.

@AlexJerabek
Copy link
Collaborator

AlexJerabek commented Aug 2, 2024

@Rick-Kirkham, Gotcha! Thank you for the clarification. So much for testing this without a test account :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: authentication Feedback on authentication content Needs: attention 👋 Waiting on Microsoft to provide feedback Type: doc bug Problem with the documentation (e.g., doc is out of date, unclear, confusing, or broken)
Projects
None yet
Development

No branches or pull requests

3 participants