Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel tabs fail schema validation #12003

Closed
BobGerman opened this issue Jul 12, 2024 · 2 comments
Closed

Channel tabs fail schema validation #12003

BobGerman opened this issue Jul 12, 2024 · 2 comments
Labels
needs attention This issue needs the attention of a contributor.

Comments

@BobGerman
Copy link

Describe the bug
Schema with a configurable tab fails validation even though it matches the schema and TDP created mainfest, and uploads manually

To Reproduce
Steps to reproduce the behavior:

  1. Generate a static tab app in Teams Toolkit (no configurable tab template exists now?)
  2. Add a configurable tab:
    "configurableTabs": [
        {
            "configurationUrl": "${{TAB_ENDPOINT}}/index.html#/tab",
            "canUpdateConfiguration": true,
            "scopes": [
                "groupChat",
                "team"
            ],
            "context": [
                "privateChatTab",
                "channelTab",
                "meetingSidePanel"
            ]
        }
    ],
  1. Hit F5 and get this error:
    (×) Error: teamsApp/extendToM365 failed.
    (×) Error: Request failed with status code 400 (tracingId: 00-cdb92b92dc8ff464ab2bf54739c3e088-34de022eb82bf43b-00) BadRequest: Manifest is not valid: [
    "Value "groupChat" is not defined in enum. Path 'configurableTabs[0].scopes[0]', line 33, position 27.

I tried bumping the manifest schema to 1.17 but got the same error

Expected behavior
I expect the schema to validate in TTK just as it does in TDP and Teams itself

VS Code Extension Information (please complete the following information):

  • OS: Windows 11
  • Version 5.8.1

Additional context
Complete manifest is here:

{
    "$schema": "https://developer.microsoft.com/en-us/json-schemas/teams/v1.15/MicrosoftTeams.schema.json",
    "manifestVersion": "1.15",
    "version": "1.0.0",
    "id": "${{TEAMS_APP_ID}}",
    "packageName": "com.microsoft.teams.extension",
    "developer": {
        "name": "Teams App, Inc.",
        "websiteUrl": "${{TAB_ENDPOINT}}",
        "privacyUrl": "${{TAB_ENDPOINT}}/index.html#/privacy",
        "termsOfUseUrl": "${{TAB_ENDPOINT}}/index.html#/termsofuse"
    },
    "icons": {
        "color": "color.png",
        "outline": "outline.png"
    },
    "name": {
        "short": "TabTest${{APP_NAME_SUFFIX}}",
        "full": "Full name for TabTest"
    },
    "description": {
        "short": "Short description of TabTest",
        "full": "Full description of TabTest"
    },
    "accentColor": "#FFFFFF",
    "bots": [],
    "composeExtensions": [],
    "configurableTabs": [
        {
            "configurationUrl": "${{TAB_ENDPOINT}}/index.html#/tab",
            "canUpdateConfiguration": true,
            "scopes": [
                "groupChat",
                "team"
            ],
            "context": [
                "privateChatTab",
                "channelTab",
                "meetingSidePanel"
            ]
        }
    ],
    "staticTabs": [
        {
            "entityId": "index",
            "name": "Personal Tab",
            "contentUrl": "${{TAB_ENDPOINT}}/index.html#/tab",
            "websiteUrl": "${{TAB_ENDPOINT}}/index.html#/tab",
            "scopes": [
                "personal"
            ]
        }
    ],
    "permissions": [
        "identity",
        "messageTeamMembers"
    ],
    "validDomains": [
        "${{TAB_DOMAIN}}"
    ],
    "webApplicationInfo": {
        "id": "${{AAD_APP_CLIENT_ID}}",
        "resource": "api://${{TAB_DOMAIN}}/${{AAD_APP_CLIENT_ID}}"
    }
}
Copy link
Contributor

Thank you for contacting us! Any issue or feedback from you is quite important to us. We will do our best to fully respond to your issue as soon as possible. Sometimes additional investigations may be needed, we will usually get back to you within 2 days by adding comments to this issue. Please stay tuned.

@microsoft-github-policy-service microsoft-github-policy-service bot added the needs attention This issue needs the attention of a contributor. label Jul 12, 2024
@BobGerman
Copy link
Author

UPDATE: Both TDP and Docs are wrong - it is "groupchat" not "groupChat"
Not sure where to file bugs against these but TTK is right everyone else is wrong!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs attention This issue needs the attention of a contributor.
Projects
None yet
Development

No branches or pull requests

1 participant