From 6577fcb8490dee9d46348959f178070cdee4f40c Mon Sep 17 00:00:00 2001 From: supkasar <157565053+supkasar@users.noreply.github.com> Date: Mon, 18 Mar 2024 17:13:51 +0530 Subject: [PATCH 1/2] docs: Update package.nls.json --- packages/fx-core/resource/package.nls.json | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/packages/fx-core/resource/package.nls.json b/packages/fx-core/resource/package.nls.json index bf725a888e..d6eeb5f749 100644 --- a/packages/fx-core/resource/package.nls.json +++ b/packages/fx-core/resource/package.nls.json @@ -352,18 +352,18 @@ "core.createProjectQuestion.OpenAIPluginDomain": "OpenAI Plugin Manifest", "core.createProjectQuestion.OpenAIPluginDomain.placeholder": "Enter your website domain or manifest URL", "core.createProjectQuestion.ApiKey": "Enter API Key in OpenAPI Description Document", - "core.createProjectQuestion.ApiKeyConfirm": "Teams Toolkit will upload the API key to Teams Developer Portal. The API key will be used by Teams client to securely access your API in runtime when API-Based Message Extension is triggered. Teams Toolkit will not store your API key.", + "core.createProjectQuestion.ApiKeyConfirm": "Teams Toolkit uploads the API key to Teams Developer Portal for secure access of API by Teams client when API-based Message Extension is triggered. Teams Toolkit doesn't store your API key.", "core.createProjectQuestion.apiMessageExtensionAuth.title": "Authentication Type", "core.createProjectQuestion.apiMessageExtensionAuth.placeholder": "Select an authentication type", - "core.createProjectQuestion.invalidApiKey.message": "Client secret is invalid. The length of secret should be >= 10 and <= 128", + "core.createProjectQuestion.invalidApiKey.message": "Enter a valid client secret between >= 10 and <= 128 characters in length", "core.createProjectQuestion.invalidUrl.message": "Enter a valid HTTP URL without authentication to access your OpenAPI description document.", "core.createProjectQuestion.apiSpec.operation.title": "Select Operation(s) Teams Can Interact with", "core.createProjectQuestion.apiSpec.copilotOperation.title": "Select Operation(s) Copilot Can Interact with", - "core.createProjectQuestion.apiSpec.operation.placeholder": "GET/POST methods with at most 5 required parameter and no auth are listed", - "core.createProjectQuestion.apiSpec.operation.apikey.placeholder": "GET/POST methods with at most 5 required parameter and API key are listed", + "core.createProjectQuestion.apiSpec.operation.placeholder": "GET/POST methods with at most 5 required parameters and no auth are listed", + "core.createProjectQuestion.apiSpec.operation.apikey.placeholder": "GET/POST methods with at most 5 required parameters and API key are listed", "core.createProjectQuestion.apiSpec.operation.invalidMessage": "%s API(s) selected. You can select at least one and at most %s APIs.", - "core.createProjectQuestion.apiSpec.operation.multipleAuth": "Your selected APIs have multiple authorizations %s which are not supported.", - "core.createProjectQuestion.apiSpec.operation.multipleServer": "Your selected APIs have multiple server URLs %s which are not supported.", + "core.createProjectQuestion.apiSpec.operation.multipleAuth": "Your selected APIs have multiple authorizations %s, which are not supported.", + "core.createProjectQuestion.apiSpec.operation.multipleServer": "Your selected APIs have multiple server URLs %s, which are not supported.", "core.createProjectQuestion.apiSpec.operation.placeholder.skipExisting": "Methods defined in manifest.json are not listed", "core.createProjectQuestion.apiSpec.multipleValidationErrors.message": "Invalid OpenAPI description document. Check output panel for details.", "core.createProjectQuestion.apiSpec.multipleValidationErrors.vscode.message": "Invalid OpenAPI description document. Check [output panel](command:fx-extension.showOutputChannel) for details.", @@ -371,22 +371,22 @@ "core.createProjectQuestion.openAiPluginManifest.validationError.missingApiUrl": "Missing URL in \"%s\".", "core.createProjectQuestion.openAiPluginManifest.validationError.authNotSupported": "Auth type is not supported. Supported auth type: \"%s\".", "core.createProjectQuestion.meArchitecture.title": "Architecture of Search Based Message Extension", - "core.createProjectQuestion.officeXMLAddin.bar.title": "Office Add-in", + "core.createProjectQuestion.officeXMLAddin.bar.title": "Office Add-ins", "core.createProjectQuestion.officeXMLAddin.bar.detail": "Creating Project.", - "core.createProjectQuestion.officeXMLAddin.mainEntry.title": "Office Add-in", + "core.createProjectQuestion.officeXMLAddin.mainEntry.title": "Office Add-ins", "core.createProjectQuestion.officeXMLAddin.mainEntry.detail": "Create integration with Outlook, Word, Excel, or PowerPoint", "core.createProjectQuestion.officeXMLAddin.create.title": "Select to create an Outlook, Word, Excel, or PowerPoint Add-in", "core.createProjectQuestion.officeXMLAddin.word.title": "Word Add-in", "core.createProjectQuestion.officeXMLAddin.word.detail": "Create an add-in that can run in Word across multiple platforms", "core.createProjectQuestion.officeXMLAddin.word.sso.title": "Add-in with Single Sign On", - "core.createProjectQuestion.officeXMLAddin.word.sso.detail": "Create a Word add-in with Single Sign On capabilities", + "core.createProjectQuestion.officeXMLAddin.word.sso.detail": "Create a Word add-in with Single Sign On", "core.createProjectQuestion.officeXMLAddin.word.react.title": "Add-in with React framework", "core.createProjectQuestion.officeXMLAddin.word.react.detail": "Create a Word add-in with React framework", "core.createProjectQuestion.officeXMLAddin.word.create.title": "Create a Word Add-in", "core.createProjectQuestion.officeXMLAddin.excel.title": "Excel Add-in", - "core.createProjectQuestion.officeXMLAddin.excel.detail": "Extend Excel functionality and access Excel data on multiple platforms", + "core.createProjectQuestion.officeXMLAddin.excel.detail": "Extend Excel functionality and access Excel data across platforms", "core.createProjectQuestion.officeXMLAddin.excel.sso.title": "Add-in with Single Sign On", - "core.createProjectQuestion.officeXMLAddin.excel.sso.detail": "Create an Excel add-in with Single Sign On capabilities", + "core.createProjectQuestion.officeXMLAddin.excel.sso.detail": "Create an Excel add-in with Single Sign On", "core.createProjectQuestion.officeXMLAddin.excel.react.title": "Add-in with React framework", "core.createProjectQuestion.officeXMLAddin.excel.react.detail": "Create an Excel add-in with React framework", "core.createProjectQuestion.officeXMLAddin.excel.cf.shared.title": "Excel Custom Functions using a Shared Runtime", From 2b5fb390da462220e3b791b877089d6d4ad768c2 Mon Sep 17 00:00:00 2001 From: supkasar <157565053+supkasar@users.noreply.github.com> Date: Wed, 20 Mar 2024 10:59:08 +0530 Subject: [PATCH 2/2] Update question.test.ts --- packages/fx-core/tests/question/question.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/fx-core/tests/question/question.test.ts b/packages/fx-core/tests/question/question.test.ts index bb559ebe4a..246e0a6b70 100644 --- a/packages/fx-core/tests/question/question.test.ts +++ b/packages/fx-core/tests/question/question.test.ts @@ -1016,7 +1016,7 @@ describe("apiKeyQuestion", async () => { const result = (validation as FuncValidation).validFunc("abc"); assert.equal( result, - "Client secret is invalid. The length of secret should be >= 10 and <= 128" + "Enter a valid client secret between >= 10 and <= 128 characters in length" ); }); });