Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.as_matrix() removed from pandas now is .values() #1

Open
Carreau opened this issue Apr 23, 2020 · 3 comments
Open

.as_matrix() removed from pandas now is .values() #1

Carreau opened this issue Apr 23, 2020 · 3 comments

Comments

@Carreau
Copy link

Carreau commented Apr 23, 2020

Hi,

It looks like as_matrix() has been deprecated since pandas 0.23 and finally been removed.

Would you be open to a pull request that update the code, and if so will you publish an updated version on PyPI ?

Thanks.

@fcarpentey75012
Copy link

Hi Carreau,

You can replace as_matrix() by .values() and keep the all code

@Carreau
Copy link
Author

Carreau commented Jun 4, 2020

You can replace as_matrix() by .values() and keep the all code

Yes, that's what my title say, but the code here does use .as_matrix() in the test and example. I'm asking if it's ok to send a PR to update.

@fcarpentey75012
Copy link

Yes, i'm sorry. I didn't read the title..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants