Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 Current pre-commit requirements and enhancements 🧪 #495

Open
jbampton opened this issue Oct 3, 2023 · 3 comments
Open

🧪 Current pre-commit requirements and enhancements 🧪 #495

jbampton opened this issue Oct 3, 2023 · 3 comments
Assignees
Labels
Enhancement New feature or request Good First Issue Good for newcomers hacktoberfest Help Wanted Extra attention is needed Question Further information is requested tests

Comments

@jbampton
Copy link
Member

jbampton commented Oct 3, 2023

With pre-commit we run:

  • clang-format
  • hadolint-docker
  • shellcheck

That means we require both clang-format and the docker executable to be pre-installed to be able to run:

pre-commit run --all-files successfully.

We also need to install pre-commit itself and I am thinking we should do this with pip and create a Make target.

That means Python itself is required too.

Which leads to a full Docker container perhaps

Are there any other requirements ?

@jbampton jbampton added Help Wanted Extra attention is needed Good First Issue Good for newcomers Question Further information is requested tests Enhancement New feature or request hacktoberfest labels Oct 3, 2023
@jbampton jbampton changed the title Current pre-commit requirements and enhancements 🧪 Current pre-commit requirements and enhancements 🧪 Oct 3, 2023
@jbampton
Copy link
Member Author

jbampton commented Oct 3, 2023

refs #447

@btwshivam
Copy link

please assign me i want to work on it

@BaseMax
Copy link
Member

BaseMax commented Oct 4, 2023

Hi my friend, welcome to the community and team.
Best wishes
-- MAX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Good First Issue Good for newcomers hacktoberfest Help Wanted Extra attention is needed Question Further information is requested tests
Projects
None yet
Development

No branches or pull requests

3 participants