Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hardcoded 60 px button height #43

Conversation

martonmiklos
Copy link
Contributor

@martonmiklos martonmiklos commented Nov 8, 2024

Softkeys worked in a weird "offseted" way before this when set to 72 px (which is the minimum for our implement).

Maybe related to #26

SoftKeyMaskRenderAreaComponent::getClickedChildRecursive
@ad3154
Copy link
Member

ad3154 commented Nov 9, 2024

Thanks for all your contributions! It's great having someone else helping.

The whitespace in this PR reminds me that I need to get a clang-format action added as well... I am fine approving it and will deal with the whitespace in a PR to add a validation action for it.

@ad3154 ad3154 self-requested a review November 9, 2024 17:42
@ad3154 ad3154 self-assigned this Nov 9, 2024
@ad3154 ad3154 merged commit 47edd65 into Open-Agriculture:main Nov 9, 2024
@martonmiklos
Copy link
Contributor Author

Thanks for all your contributions! It's great having someone else helping.

The whitespace in this PR reminds me that I need to get a clang-format action added as well... I am fine approving it and will deal with the whitespace in a PR to add a validation action for it.

I need say thank you for all the invested time! It is very impressing what you have acheived.

I have been able to iron out the most of the issues with our VT app, so I have a couple PRs coming (both to VT and the stack), just I need to dig deeper in the standards before submitting. Other than our VT implement we have a couple Iso implements lying around, I will give them a try to see if there are anything what needs to be fixed.

The formatting issues are my faults,
I have not been able to setup my QtCreator to mimic 100%ly the format specified in the clang-format so I tried to manually tailor the code before commit. Having a commit hook or a PR validation would certainly a great addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants