Skip to content

Latest commit

 

History

History
122 lines (90 loc) · 4.42 KB

CONTRIBUTING.md

File metadata and controls

122 lines (90 loc) · 4.42 KB
Raw

Open CAS Telemetry Framework Contributing

Table of Contents:

License

OCTF is distributed on BSD-3-Clause license. Please navigate here for full license text.

Issue tracking

Issues and potential feature requests are tracked using Github Issues mechanism. It is advised to label issue to indicate its type (e.g. defect, feature request, etc.)

Reporting sighting/defect

When submitting a defect report it is advised to provide all the relevant information to reproduce the issue. This ideally includes:

  • SW configuration, such as: Linux distribution version, Linux kernel version.
  • Steps to reproduce (e.g. simple script with indication of failing steps).

Feature request

To submit feature request please provide information on the usage scenario, feature requirements and expected implementation timeline for the feature. This information will help Open CAS community to plan feature implementation.

Contributing

All contributions are welcome! Don't hesitate to submit a pull request! Patch submission requirements:

  • Contributions are accepted on BSD-3-Clause license.
  • All patches must be signed off by the developer, which indicates that submitter agrees to the Developer Certificate of Origin (DCO).
  • Commits must conform to OCTF coding standard.
  • Commits should build and pass tests.
  • Commits should contain a clear message describing purpose of the commit (e.g. bug fix, improvement, etc.). Ideal commit description should provide information on why change is needed (e.g. what problem is being solved) and how this change solves the problem.

Example commit with title, description and signoff information:

commit 6598b61a478d44c26e3147baec6ce002a4c77fa8 (HEAD -> contributions)
Author: John Doe <john.doe@example_org.com>
Date:   Thu Jan 17 22:06:10 2019 -0700

    Example change fixing SW problem

    This change fixes a SW crash occurring when software is used in
    scenario A, B and C. That crash impacts user data availability.
    This commit fixes this problem by introducing following changes.

    Signed-off-by: John Doe <john.doe@example_org.com>

Code review is performed using GitHub. 2 approves are required for the pull request to be merged into main branch.

Typical flow for introducing changes

Usually development starts with cloning and checking out recent 'master' branch, where you will start introducing your changes. To create a new local branch named 'my_changes', based off 'origin/master' branch run following command.

git fetch
git checkout -b my_changes origin/master

Introduce changes to the desired files and commit changes to the local repository. Edit commit title and description. Common practices to maintain good commit description is to adhere to following rules:

  1. Separate commit title from description.
  2. Commit title message should be short (less than 50 characters) and should summarize the change. Start title with capital letter, do not end with a period.
  3. Longer commit description should come after title and should be separated with single a blank line. Message should wrap at 72 characters and provide description for the change explaining what, why, how.
  4. Make sure that your name and email address for author and signoff sections are correct.
# Stage files for commit
git add example_file.txt

# Commit files locally
git commit --signoff

Finally push the branch containing changes to the remote repository and open new pull request on the github.

git push my_changes origin

Maintainers

Maintainers primary responsibility is to provide technical guidance on contributions, perform code review and oversight of project direction. In case of any questions feel free to contact maintainers.