Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode support is not complete #2024

Open
Neustradamus opened this issue Nov 14, 2024 · 9 comments
Open

Dark Mode support is not complete #2024

Neustradamus opened this issue Nov 14, 2024 · 9 comments

Comments

@Neustradamus
Copy link

Describe the bug

Dear @Open-Shell team, @ge0rdi,

There is a problem, I have Windows Dark mode enabled and I have the right Start Menu in blue:

Can you solve it?

Thanks in advance.

Area of issue

Start menu

To reproduce

Select "Start" > "Settings" > Select "Personalization" > "Colors" > Under Choose your color, select Dark.

Open "Open-Shell Menu Settings" > "Backup" > Select "Reset all settings" > "Yes" > "OK" to close the settings window.

Open the Start menu to see that there is always the specified problem.

Expected behavior

Look the screenshot, the blue part must be "Dark" like other parts.

Open-Shell version

4.4.191

Windows version

Windows 10 22H2

Additional context

No response

@Neustradamus Neustradamus added the Bug Something isn't working right. label Nov 14, 2024
@ge0rdi
Copy link
Member

ge0rdi commented Nov 14, 2024

This is by design.
Default Immersive skin uses accent color you have set in Windows settings.

If you don't like that, you can use different skin.

@ge0rdi ge0rdi removed the Bug Something isn't working right. label Nov 14, 2024
@Neustradamus
Copy link
Author

@ge0rdi: Can you update the default skin to be perfect?

And add another skin like the current?

@roberto-gigli
Copy link

I might suggest that this could be an option under the Skin tab:

Transparency style:

  • Two-tone
  • Full Glass
  • No accent

@ge0rdi
Copy link
Member

ge0rdi commented Nov 15, 2024

I might suggest that this could be an option under the Skin tab

Feel free to submit this concrete idea as an improvement.

@roberto-gigli
Copy link

Do you mean submit a pull request with the improvement or a post in the Discussion of the project?

@ge0rdi
Copy link
Member

ge0rdi commented Nov 15, 2024

Sorry, I meant Feature request:
https://github.com/Open-Shell/Open-Shell-Menu/issues/new/choose

@CTVCAM8
Copy link

CTVCAM8 commented Dec 17, 2024

Actually, there already is an option under the skin tab.
It is called "Reduce glass color".

If you are up to editing the skin file to make the grey menu darker,
The text in the skin is:

[DISABLE_MASK]
Main_bitmap_tint1=#545454
Main_bitmap_search_tint1=#545454
Main_bitmap_jump_tint1=#545454
Programs_background_tint1=#545454
Scrollbar_button_tint1=#545454
Scrollbar_thumb_tint1=#545454
Scrollbar_background_tint1=#545454

Making the Hex color values lower, will make the grey menu parts darker.

@CTVCAM8
Copy link

CTVCAM8 commented Dec 17, 2024

My bad.
I just realized if you leave the "Reduce glass color" disabled,
you can go to the "Menu Look tab",
enable "Override glass color" and set any color you want.

Good job bonzibudd

@CTVCAM8
Copy link

CTVCAM8 commented Dec 17, 2024

I find your modified screenshot a bit confusing.
I was thinking was that some type of Immersive modified skin?
After looking at it one more time, I guess the white parts are covering up personal text?

There is another thing you might want to try.
Forget everything from my previous comments,
and go back to doing it with your Windows 10 Personalization settings,
but add the important setting that is picking an Accent color.

Accent color

Personally, I still like using Open Shell Override glass color, as I can make the color black.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants