[Implemented] Should {tlf}
be a hard or a soft dependency?
#921
IndrajeetPatil
started this conversation in
General
Replies: 2 comments
-
Actually I am for mandatory. I would hate it to suddenly realize that some functionality of the package does not work because a dependency is optional. |
Beta Was this translation helpful? Give feedback.
0 replies
-
ok, let's make it mandatory then |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
@Yuri05 had mentioned the following:
@IndrajeetPatil @PavelBal @msevestre
Do we want to have
tlf
andpatchwork
as mandatory prerequisites (like now) or is it sufficient to have them as optional prereqs?I would vote for optional, because - except for plots -
ospsuite
is still fully functional without those packages installed.Originally posted by @Yuri05 in #882 (comment)
{tlf}
can be in the ospsuiteNAMESPACE
and the plot grid functions/classes can't be re-exported, like so:Just wanted to make sure that the team was on-board with this before I made the necessary changes.
Beta Was this translation helpful? Give feedback.
All reactions