Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect login when token is expired - Fix on login errors #1794

Open
isselparra opened this issue Oct 31, 2024 · 1 comment
Open

Redirect login when token is expired - Fix on login errors #1794

isselparra opened this issue Oct 31, 2024 · 1 comment
Labels
bug use for describing something not working as expected
Milestone

Comments

@isselparra
Copy link
Member

Use case

Current Workaround

Proposed Solution

Use error boundary

Additional Information

Following this issue : Issue #647 we did a fix that is not ideal : we recreate the session everytime right before the login instead of using the existing one. It has no impact as it’s only right before the login, when the user doesn’t really have anything in the session but it’s kind of ugly. We need to check if we can remove it when we’ll upgrade the saml library.

@isselparra isselparra added feature use for describing a new feature to develop needs triage use to identify issue needing triage from Filigran Product team labels Oct 31, 2024
@isselparra isselparra changed the title Redirect login when token is expired Redirect login when token is expired - Fix on login errors Oct 31, 2024
@EllynBsc EllynBsc added bug use for describing something not working as expected and removed needs triage use to identify issue needing triage from Filigran Product team feature use for describing a new feature to develop labels Oct 31, 2024
@EllynBsc EllynBsc added this to the Bugs backlog milestone Oct 31, 2024
@EllynBsc
Copy link
Member

Hi @isselparra 👋 ,

As discussed, this is more a bug than a feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected
Projects
None yet
Development

No branches or pull requests

2 participants