New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TaskSolving的role_assign方法在处理专家列表的赋值时很混乱。 #126

Open

401lrx opened this issue Mar 23, 2024 · 0 comments

401lrx commented Mar 23, 2024

role_assign方法的参数的类型标注有错误，同时局部变量和传入参数命名冲突了。这部分提交了修复的pr。
在进行role_assigner的astep时，传入Solver Agent导致Solver Agent的name会被覆盖掉。例如在brainstorming任务中，solver的名称本应该是Summarizer，他的工作也只是总结历史聊天信息，但在专家招募后，他的名字会变成例如：a civil engineer specializing in infrastructure development。这里似乎是不正确的行为。
专家列表的属性更新实际上是在role_assigner的astep中做的，并且会检查人员数量保持相同。所以在首轮招募时，判断role_assign_only_once以及cnt_turn再进行一次赋值操作的代码似乎是多余的。

相关pr：
#125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment