Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed how BSS fetches a new token #26

Merged
merged 9 commits into from
Mar 25, 2024

Conversation

davidallendj
Copy link
Contributor

This PR changes how BSS fetches an access token. It adds a single FetchAccessToken function that is used in place of the functions used to perform a client credentials grant. It also changes the loadPublicKeyFromURL function to fetchPublicKey and moves it to the oauth.go file.

cmd/boot-script-service/oauth.go Outdated Show resolved Hide resolved
cmd/boot-script-service/oauth.go Show resolved Hide resolved
cmd/boot-script-service/oauth.go Outdated Show resolved Hide resolved
cmd/boot-script-service/oauth.go Outdated Show resolved Hide resolved
cmd/boot-script-service/oauth.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@synackd synackd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passing! Just a few housekeeping things and this should be ready for merge.

cmd/boot-script-service/oauth.go Show resolved Hide resolved
cmd/boot-script-service/oauth.go Show resolved Hide resolved
@davidallendj davidallendj added enhancement New feature or request and removed needs testing labels Mar 25, 2024
@synackd
Copy link
Collaborator

synackd commented Mar 25, 2024

We should also change the default OAUTH2 URLs to point to OPAAL for now instead of hydra.

diff --git a/cmd/boot-script-service/main.go b/cmd/boot-script-service/main.go
index 7dc23f7..177f0d7 100644
--- a/cmd/boot-script-service/main.go
+++ b/cmd/boot-script-service/main.go
@@ -102,8 +102,8 @@ var (
        jwksURL             = ""
        sqlDbOpts           = ""
        spireServiceURL     = "https://spire-tokens.spire:54440"
-       oauth2AdminBaseURL  = "http://127.0.0.1:4445"
-       oauth2PublicBaseURL = "http://127.0.0.1:4444"
+       oauth2AdminBaseURL  = "http://127.0.0.1:3333"
+       oauth2PublicBaseURL = "http://127.0.0.1:3333"
 )
 

@synackd
Copy link
Collaborator

synackd commented Mar 25, 2024

LGTM!

@davidallendj davidallendj merged commit 929721d into OpenCHAMI:main Mar 25, 2024
1 check passed
@davidallendj davidallendj deleted the bss-token-fetch branch April 8, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants