-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alexlovelltroy/build improvements #48
Conversation
* Refactor build_release.yml and unit_test.yaml workflows * Modernize the .goreleaser * Replace .version with LDFLAG-based versioning * Add multiarch container * Add native packaging ro deb, rpm, and apk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made two inquiries about the changes, but neither are necessarily blockers.
…in through hms-hmsetcd
We should probably also update the README with build instructions using goreleaser (e.g. setting the env vars). |
Commenting here for posterity: Otherwise one will get the following error:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build works using Goreleaser >=2.4 and I was able to test the amd64 container. I haven't been able to test arm64 yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested goreleaser on the same amd64 machines and worked on all of them.
I obviously couldn't test the GitHub actions stuff, but found a small thing that should be fixed before merging.
Also, can we add the environment variable setting instructions for Goreleaser to the README (e.g. this)? I think the instructions are helpful for building locally, but also it's useful to, when building locally, do something like
eval $(grep ^export README.md)
to automatically source those variables.
Also, I am seeing go.mod and go.sum changes when I run goreleaser. |
* README for goreleaser instructions * go mod tidy * v4->v3 in attestation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is resolved, LGTM.
Adding build automation from the work I did for smd that leads to better version reporting, multiarch containers, and native packages