Build Improvements #1
Conversation
alexlovelltroy
commented
Oct 29, 2024
alexlovelltroy
commented
- Add .goreleaser.yml
- Update Dockerfile to use goreleaser
- Use the version information more consistent with smd
- Use coredhcp-generator without cloning it.
* Add .goreleaser.yml * Update Dockerfile to use goreleaser * Use the version information more consistent with smd * Use coredhcp-generator without cloning it.
There was a problem hiding this comment.
Not really a big deal, but typo in the file name if it's meant to be "release.yaml".
| goamd64: | ||
| - v3 | ||
|
|
||
| # export GIT_STATE=$(if git diff-index --quiet HEAD --; then echo 'clean'; else echo 'dirty'; fi) |
There was a problem hiding this comment.
Can this be removed since the vars are defined in Realease.yaml?
There was a problem hiding this comment.
I left it in as a comment so that people who are using goreleaser locally have a guide to follow.
|
I'm going to go ahead a approve since the comments aren't blocking. |
|
|
||
| 1. Run GoReleaser in snapshot mode with the --snapshot and --skip-publish flags to create a local build without attempting to release it: | ||
| ```bash | ||
| goreleaser release --snapshot --skip-publish --clean |
There was a problem hiding this comment.
--skip-publish should be --skip publish.
There was a problem hiding this comment.
Tested on cluster and --skip-publish wasn't recognized as an option but --skip publush was.
| # | ||
| # STEP 1: Clone coredhcp and build coredhcp-generator | ||
| # | ||
| # Include curl in the final image. |
There was a problem hiding this comment.
Do you mean tini instead of curl?
|
just merged. I'll fix the two typos and re-submit |
