Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Improvements (Part 2) #3

Merged
merged 17 commits into from
Nov 7, 2024
Merged

Build Improvements (Part 2) #3

merged 17 commits into from
Nov 7, 2024

Conversation

synackd
Copy link
Collaborator

@synackd synackd commented Nov 7, 2024

Amends #1

  • Re-enable CGO (needed for sqlite3 storage backend for the bootloop plugin)
  • Update paths of built binary and permanent resources (now in resources/)
  • Add CoreDHCP commit hash as comment in source template
  • Reformat README.md additions to match formatting of rest of file
  • Correct --skip option for Goreleaser in README

alexlovelltroy and others added 17 commits October 30, 2024 15:05
@alexlovelltroy
minor fixups of existing PR
63c14e4
@synackd
chore(coredhcp): comment CoreDHCP commit file was generated from
1499781
@synackd
docs(README.md): make new material match format of rest of file
718e8ee
@synackd
build: differentiate goreleaser and local dockerfiles
044611a
@synackd
docs(README.md): differentiate dockerfiles
755efc6
@synackd
chore: move permanent resources from dist/ to resources/
f4ca993
@synackd
chore(docker): fix comment referencing curl (should be tini)
834548b
@synackd
build(docker): add version setting to Dockerfile
02464d4
@synackd
build: delete gen_version.bash
8e32993
@synackd
build: add basic Makefile
3d2a6ba
@synackd
build: move cmd/ to coredhcp/ and delete coredhcp.go
923dd8c
@synackd
Revert "build: add basic Makefile"
6d2b0a7 
This reverts commit 3d2a6ba.
@synackd
Revert "build(docker): add version setting to Dockerfile"
2d40aae 
This reverts commit 02464d4.
@synackd
Revert "chore(docker): fix comment referencing curl (should be tini)"
8e8666e 
This reverts commit 834548b.
@synackd
Revert "docs(README.md): differentiate dockerfiles"
ee60e21 
This reverts commit 755efc6.
@synackd
Revert "build: differentiate goreleaser and local dockerfiles"
2e4e5d8 
This reverts commit 044611a.
@synackd
build(goreleaser): enable CGO
223f300 
This is required for sqlite3, which is used as the storage backend for
bootloop.
alexlovelltroy
alexlovelltroy approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@alexlovelltroy alexlovelltroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great additions. SHIP IT!

@alexlovelltroy alexlovelltroy merged commit 049c7b8 into main Nov 7, 2024
@synackd synackd deleted the alexlovelltroy/build-improvements branch November 7, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexlovelltroy alexlovelltroy alexlovelltroy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@synackd @alexlovelltroy