Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update Go version #66

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Conversation

alexlovelltroy
Copy link
Member

This commit updates the Go version to the latest stable release and adds QEMU setup to the GitHub workflow. It also sets up the necessary environment variables required by GoReleaser. These changes ensure that the project is using the latest Go version and is ready for release.

Adds support for more architectures, package types, and better docker image.

This commit updates the Go version to the latest stable release and adds QEMU setup to the GitHub workflow. It also sets up the necessary environment variables required by GoReleaser. These changes ensure that the project is using the latest Go version and is ready for release.

Adds support for more architectures, package types, and better docker image.
cmd/version.go Outdated Show resolved Hide resolved
cmd/version.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@davidallendj davidallendj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments here, but I think moving the version implementation into internal/version/version.go like the other repos is the most important one.

@alexlovelltroy
Copy link
Member Author

Agreed about moving it. I'm actually working on exactly that right now.

I left the VersionInfo string in the version.go file so that if we ever do use it, we have the same format in all software.

People have asked for windows binaries before and it was pretty easy to add. We can remove if problematic.

@davidallendj
Copy link
Collaborator

Agreed about moving it. I'm actually working on exactly that right now.

I left the VersionInfo string in the version.go file so that if we ever do use it, we have the same format in all software.

People have asked for windows binaries before and it was pretty easy to add. We can remove if problematic.

I don't think adding Windows binaries should be problematic, but it was the first time seeing it so I'm interested in seeing how that turns out.

As for the VersionInfo string, that seems to me like it would make sense in a common library but I don't think we currently have one. I think we also had a discussion before about trying to avoid having something like hms-base as well.

Copy link
Collaborator

@davidallendj davidallendj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexlovelltroy alexlovelltroy merged commit 4588a8b into main Oct 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants