BUG: Clubs shouldn't be able to book more than 12 places per competition #4

dompatmore · 2020-07-03T11:14:50Z

When:

A secretary tries to book more than 12 places in one competition

Then:

Those places are confirmed

Expected:

They should be able to book no more than 12 places.
The UI should prevent them from booking more than 12 places. 
The places are correctly deducted from the competition.

The text was updated successfully, but these errors were encountered:

and OpenClassrooms-Student-Center#5 + refactoring

…e - fix and tests - UI: welcome.html: link 'book' not available when no more place to book for competition - UI: booking.html: HTML input for booking: max is set dynamically, depending on club['points'], competition['numberOfPlaces'] and maximum places to book - Tests: test_should_not_book_over_limit - Tests: test_should_not_book_negative_places

…le - Tests Improvements - Tests: class TestEndPoints: test_book_authenticated_user_should_200 - Tests: class TestEndPoints: test_book_unauthenticated_user_should_get_wrong - Tests: class TestPurchase: test_should_bad_request_keys_400 - Tests: class TestPurchase: test_should_bad_request_values_400 - Tests: class TestPurchase: test_should_bad_request_empty_values_400

…Student-Center#4)

…hon_Testing

Merge branch issue OpenClassrooms-Student-Center#4

…r competition #4

Places are limited to 12 per club for a competition Issue OpenClassrooms-Student-Center#4

Issue OpenClassrooms-Student-Center#4

Issue OpenClassrooms-Student-Center#4 Fixed Issue OpenClassrooms-Student-Center#6 Fixed Some parts of the tree structure for the tests have been modified.

* feat(board.html): add template for points display board * feat(server): add route for points display board * feat(board.html): complete template * test(test_points_board): start testing happy path * feat(board.html): add condition if no clubs in json * test(test_points_board): add sad path to test * test(units/): add test_unlimited_points.py * fix(server): add condition to limit purchase * fix(booking.html): add display of flash message * test(units/): test_unlimited_points.py passed * test(units/): change docstrings in test_unlimited_points.py * test(units/): done test_unlimited_points.py * fix(issue): [OpenClassrooms-Student-Center#2] * test(units/): add test_points_not_update.py with TDD approch added test and failed * fix(server): add substraction points after book places * test(units/): run test_points_not_update.py and passed * fix(issue): [OpenClassrooms-Student-Center#6] * test(units/): add test_book_under_12.py with TDD method: started with failed test * fix(server): add condition if book more 12 places * test(units/): complete test_book_under_12.py and run tests passed * fix(issue): [OpenClassrooms-Student-Center#4]

* feat(board.html): add template for points display board * feat(server): add route for points display board * feat(board.html): complete template * test(test_points_board): start testing happy path * feat(board.html): add condition if no clubs in json * test(test_points_board): add sad path to test * test(units/): add test_unlimited_points.py * fix(server): add condition to limit purchase * fix(booking.html): add display of flash message * test(units/): test_unlimited_points.py passed * test(units/): change docstrings in test_unlimited_points.py * test(units/): done test_unlimited_points.py * fix(issue): [OpenClassrooms-Student-Center#2] * test(units/): add test_points_not_update.py with TDD approch added test and failed * fix(server): add substraction points after book places * test(units/): run test_points_not_update.py and passed * fix(issue): [OpenClassrooms-Student-Center#6] * test(units/): add test_book_under_12.py with TDD method: started with failed test * fix(server): add condition if book more 12 places * test(units/): complete test_book_under_12.py and run tests passed * fix(issue): [OpenClassrooms-Student-Center#4] * test(functional/): add & complete test_route.py * fix(404.html): add 404 handler and template * fix(500.html): add 500 handler and template * test(functional/): add & complete test_load_json.py

* feat(board.html): add template for points display board * feat(server): add route for points display board * feat(board.html): complete template * test(test_points_board): start testing happy path * feat(board.html): add condition if no clubs in json * test(test_points_board): add sad path to test * test(units/): add test_unlimited_points.py * fix(server): add condition to limit purchase * fix(booking.html): add display of flash message * test(units/): test_unlimited_points.py passed * test(units/): change docstrings in test_unlimited_points.py * test(units/): done test_unlimited_points.py * fix(issue): [OpenClassrooms-Student-Center#2] * test(units/): add test_points_not_update.py with TDD approch added test and failed * fix(server): add substraction points after book places * test(units/): run test_points_not_update.py and passed * fix(issue): [OpenClassrooms-Student-Center#6] * test(units/): add test_book_under_12.py with TDD method: started with failed test * fix(server): add condition if book more 12 places * test(units/): complete test_book_under_12.py and run tests passed * fix(issue): [OpenClassrooms-Student-Center#4] * test(functional/): add & complete test_route.py * fix(404.html): add 404 handler and template * fix(500.html): add 500 handler and template * test(functional/): add & complete test_load_json.py * test(integration/): add & complete test of app * fix(server): issue book more than places available * test(integration/): cleanup test_app

* feat(board.html): add template for points display board * feat(server): add route for points display board * feat(board.html): complete template * test(test_points_board): start testing happy path * feat(board.html): add condition if no clubs in json * test(test_points_board): add sad path to test * test(units/): add test_unlimited_points.py * fix(server): add condition to limit purchase * fix(booking.html): add display of flash message * test(units/): test_unlimited_points.py passed * test(units/): change docstrings in test_unlimited_points.py * test(units/): done test_unlimited_points.py * fix(issue): [OpenClassrooms-Student-Center#2] * test(units/): add test_points_not_update.py with TDD approch added test and failed * fix(server): add substraction points after book places * test(units/): run test_points_not_update.py and passed * fix(issue): [OpenClassrooms-Student-Center#6] * test(units/): add test_book_under_12.py with TDD method: started with failed test * fix(server): add condition if book more 12 places * test(units/): complete test_book_under_12.py and run tests passed * fix(issue): [OpenClassrooms-Student-Center#4] * test(functional/): add & complete test_route.py * fix(404.html): add 404 handler and template * fix(500.html): add 500 handler and template * test(functional/): add & complete test_load_json.py * test(integration/): add & complete test of app * fix(server): issue book more than places available * test(integration/): cleanup test_app * test(coverage/): make changes to have 100% test coverage

* feat(board.html): add template for points display board * feat(server): add route for points display board * feat(board.html): complete template * test(test_points_board): start testing happy path * feat(board.html): add condition if no clubs in json * test(test_points_board): add sad path to test * test(units/): add test_unlimited_points.py * fix(server): add condition to limit purchase * fix(booking.html): add display of flash message * test(units/): test_unlimited_points.py passed * test(units/): change docstrings in test_unlimited_points.py * test(units/): done test_unlimited_points.py * fix(issue): [OpenClassrooms-Student-Center#2] * test(units/): add test_points_not_update.py with TDD approch added test and failed * fix(server): add substraction points after book places * test(units/): run test_points_not_update.py and passed * fix(issue): [OpenClassrooms-Student-Center#6] * test(units/): add test_book_under_12.py with TDD method: started with failed test * fix(server): add condition if book more 12 places * test(units/): complete test_book_under_12.py and run tests passed * fix(issue): [OpenClassrooms-Student-Center#4] * test(functional/): add & complete test_route.py * fix(404.html): add 404 handler and template * fix(500.html): add 500 handler and template * test(functional/): add & complete test_load_json.py * test(integration/): add & complete test of app * fix(server): issue book more than places available * test(integration/): cleanup test_app * test(coverage/): make changes to have 100% test coverage * test(requirements.txt): install Locust * test(performance/): configure locust * test(performance/): add README

* feat(board.html): add template for points display board * feat(server): add route for points display board * feat(board.html): complete template * test(test_points_board): start testing happy path * feat(board.html): add condition if no clubs in json * test(test_points_board): add sad path to test * test(units/): add test_unlimited_points.py * fix(server): add condition to limit purchase * fix(booking.html): add display of flash message * test(units/): test_unlimited_points.py passed * test(units/): change docstrings in test_unlimited_points.py * test(units/): done test_unlimited_points.py * fix(issue): [OpenClassrooms-Student-Center#2] * test(units/): add test_points_not_update.py with TDD approch added test and failed * fix(server): add substraction points after book places * test(units/): run test_points_not_update.py and passed * fix(issue): [OpenClassrooms-Student-Center#6] * test(units/): add test_book_under_12.py with TDD method: started with failed test * fix(server): add condition if book more 12 places * test(units/): complete test_book_under_12.py and run tests passed * fix(issue): [OpenClassrooms-Student-Center#4] * test(functional/): add & complete test_route.py * fix(404.html): add 404 handler and template * fix(500.html): add 500 handler and template * test(functional/): add & complete test_load_json.py * test(integration/): add & complete test of app * fix(server): issue book more than places available * test(integration/): cleanup test_app * test(coverage/): make changes to have 100% test coverage * test(requirements.txt): install Locust * test(performance/): configure locust * test(performance/): add README * refactor(app): flake8 html report 100% clean * refactor(app): remove unused fixtures

* feat(board.html): add template for points display board * feat(server): add route for points display board * feat(board.html): complete template * test(test_points_board): start testing happy path * feat(board.html): add condition if no clubs in json * test(test_points_board): add sad path to test * test(units/): add test_unlimited_points.py * fix(server): add condition to limit purchase * fix(booking.html): add display of flash message * test(units/): test_unlimited_points.py passed * test(units/): change docstrings in test_unlimited_points.py * test(units/): done test_unlimited_points.py * fix(issue): [OpenClassrooms-Student-Center#2] * test(units/): add test_points_not_update.py with TDD approch added test and failed * fix(server): add substraction points after book places * test(units/): run test_points_not_update.py and passed * fix(issue): [OpenClassrooms-Student-Center#6] * test(units/): add test_book_under_12.py with TDD method: started with failed test * fix(server): add condition if book more 12 places * test(units/): complete test_book_under_12.py and run tests passed * fix(issue): [OpenClassrooms-Student-Center#4] * test(functional/): add & complete test_route.py * fix(404.html): add 404 handler and template * fix(500.html): add 500 handler and template * test(functional/): add & complete test_load_json.py * test(integration/): add & complete test of app * fix(server): issue book more than places available * test(integration/): cleanup test_app * test(coverage/): make changes to have 100% test coverage * test(requirements.txt): install Locust * test(performance/): configure locust * test(performance/): add README * refactor(app): flake8 html report 100% clean * refactor(app): remove unused fixtures * fix(welcome.hmtl): adde operator = to fix bug

* feat(board.html): add template for points display board * feat(server): add route for points display board * feat(board.html): complete template * test(test_points_board): start testing happy path * feat(board.html): add condition if no clubs in json * test(test_points_board): add sad path to test * test(units/): add test_unlimited_points.py * fix(server): add condition to limit purchase * fix(booking.html): add display of flash message * test(units/): test_unlimited_points.py passed * test(units/): change docstrings in test_unlimited_points.py * test(units/): done test_unlimited_points.py * fix(issue): [OpenClassrooms-Student-Center#2] * test(units/): add test_points_not_update.py with TDD approch added test and failed * fix(server): add substraction points after book places * test(units/): run test_points_not_update.py and passed * fix(issue): [OpenClassrooms-Student-Center#6] * test(units/): add test_book_under_12.py with TDD method: started with failed test * fix(server): add condition if book more 12 places * test(units/): complete test_book_under_12.py and run tests passed * fix(issue): [OpenClassrooms-Student-Center#4] * test(functional/): add & complete test_route.py * fix(404.html): add 404 handler and template * fix(500.html): add 500 handler and template * test(functional/): add & complete test_load_json.py * test(integration/): add & complete test of app * fix(server): issue book more than places available * test(integration/): cleanup test_app * test(coverage/): make changes to have 100% test coverage * test(requirements.txt): install Locust * test(performance/): configure locust * test(performance/): add README * refactor(app): flake8 html report 100% clean * refactor(app): remove unused fixtures * fix(welcome.hmtl): adde operator = to fix bug * style(app): add css

…ompetition OpenClassrooms-Student-Center#4

…tween club points & 12

to respect the app specifications and closes some issues Resolves OpenClassrooms-Student-Center#2, resolves OpenClassrooms-Student-Center#4, resolves OpenClassrooms-Student-Center#5, resolves OpenClassrooms-Student-Center#6,

Issue OpenClassrooms-Student-Center#4

…etitions.json

PabloLec added a commit to PabloLec/oc_gudlift that referenced this issue Jul 6, 2021

Fix #1, OpenClassrooms-Student-Center#2, OpenClassrooms-Student-Center#4

0d624ed

and OpenClassrooms-Student-Center#5 + refactoring

mjeammet added a commit to mjeammet/DAPY-P11_gudlft that referenced this issue Dec 28, 2021

clubs cannot book more than allowed/available (#2 and OpenClassrooms-…

c0caa41

…Student-Center#4)

ribandgel pushed a commit to ribandgel/Python_Testing that referenced this issue Mar 17, 2022

Fixes OpenClassrooms-Student-Center#4

652992e

zionhigt referenced this issue in zionhigt/Python_Testing Mar 27, 2022

TESTS issue #4

5393af0

zionhigt referenced this issue in zionhigt/Python_Testing Mar 27, 2022

IMPROVE TESTS issue #4

1f02813

zionhigt referenced this issue in zionhigt/Python_Testing Mar 27, 2022

FIX issue #4

d36ff3b

josayko added a commit to josayko-courses/p11_gudlft that referenced this issue Apr 19, 2022

Fix OpenClassrooms-Student-Center#4 OpenClassrooms-Student-Center/Pyt…

e9b5c3c

…hon_Testing

Luc-Aka-Evy added a commit to Luc-Aka-Evy/Gudlift that referenced this issue May 19, 2022

fix issue OpenClassrooms-Student-Center/Python_Testing#4

e2d03b2

Aponovi added a commit to Aponovi/Python_Testing that referenced this issue May 30, 2022

fix issue OpenClassrooms-Student-Center#4

9998e76

Aponovi added a commit to Aponovi/Python_Testing that referenced this issue May 30, 2022

fix issue OpenClassrooms-Student-Center#4

d546e2e

SelHel added a commit to SelHel/Python_Testing that referenced this issue Jun 9, 2022

Ajout de la branch de l'issue OpenClassrooms-Student-Center#4

d47834f

SelHel added a commit to SelHel/Python_Testing that referenced this issue Jun 13, 2022

Test bug OpenClassrooms-Student-Center#4

8210cf0

SelHel added a commit to SelHel/Python_Testing that referenced this issue Jun 13, 2022

Test and fix issue OpenClassrooms-Student-Center#4

74221d1

jogubo pushed a commit to jogubo/oc-python-testing that referenced this issue Jun 13, 2022

create test for issue OpenClassrooms-Student-Center#4

6b34200

jogubo pushed a commit to jogubo/oc-python-testing that referenced this issue Jun 13, 2022

fix issue OpenClassrooms-Student-Center#4

68193a5

SelHel added a commit to SelHel/Python_Testing that referenced this issue Jun 14, 2022

Merge branch issue OpenClassrooms-Student-Center#4

69fad35

SelHel added a commit to SelHel/Python_Testing that referenced this issue Jun 14, 2022

Merge branch 'BUG/Booking_places_in_past_competitions' into develop

24383d4

Merge branch issue OpenClassrooms-Student-Center#4

pVerneuil referenced this issue in pVerneuil/P11_Python_Testing Jun 17, 2022

bugfix: issu#4 Clubs shouldn't be able to book more than 12 places pe…

82b6560

…r competition #4

pVerneuil mentioned this issue Jun 17, 2022

bugfix: issu#4 Clubs shouldn't be able to book more than 12 places pe… pVerneuil/P11_Python_Testing#3

Merged

Deadjuju added a commit to Deadjuju/P11_OC_Python_Testing that referenced this issue Jul 11, 2022

fix(server): limit the places available

d990292

Places are limited to 12 per club for a competition Issue OpenClassrooms-Student-Center#4

Deadjuju added a commit to Deadjuju/P11_OC_Python_Testing that referenced this issue Jul 11, 2022

feat(booking.html): add limit 12 to number input

f8e8f08

Issue OpenClassrooms-Student-Center#4

Papiex mentioned this issue Jul 21, 2022

add condtion for take 12 places max #74

Closed

edaucohe mentioned this issue Aug 31, 2022

Bug/test booking places edaucohe/p11_python_testing#4

Merged

ghost mentioned this issue Oct 24, 2022

bugfix/set-maximum-of-places-per-competitions celia-tois/gudlift-registration-app#3

Merged

theyadev mentioned this issue Oct 28, 2022

BUG: Clubs should not be able to use more than their points allowed theyadev/P11_OC#2

Merged

Rossignol-h added a commit to Rossignol-h/P11_Python_Testing that referenced this issue Nov 5, 2022

fix(issue): [OpenClassrooms-Student-Center#4]

68d0b9f

Mattgris6 added a commit to Mattgris6/OC_DAPython_Projet11_Gudlft that referenced this issue Nov 17, 2022

Fix and test OpenClassrooms-Student-Center#4

ccc1574

selaouni added a commit to selaouni/Projet11 that referenced this issue Dec 5, 2022

Bug fixing: Clubs shouldn't be able to book more than 12 places per c…

2f62717

…ompetition OpenClassrooms-Student-Center#4

selaouni added a commit to selaouni/Projet11 that referenced this issue Dec 5, 2022

Bug fixing: Clubs shouldn't be able to book more than 12 places per c…

41403fd

…ompetition OpenClassrooms-Student-Center#4

selaouni added a commit to selaouni/Projet11 that referenced this issue Dec 8, 2022

bug nbr OpenClassrooms-Student-Center#4 fixing: update

d00d650

VisualDev-FR added a commit to VisualDev-FR/openclassrooms-P11 that referenced this issue Apr 21, 2023

OpenClassrooms-Student-Center#4

0de653f

VisualDev-FR added a commit to VisualDev-FR/openclassrooms-P11 that referenced this issue Apr 21, 2023

Fixes OpenClassrooms-Student-Center#4

32be87f

Jighart mentioned this issue Apr 25, 2023

Bug/booking places in past competitions Jighart/P11-Gudlft#19

Merged

JLenseele added a commit to JLenseele/Project_11 that referenced this issue Apr 27, 2023

fix OpenClassrooms-Student-Center#4 issue -> book-set a max places be…

3e5c8eb

…tween club points & 12

EnguerrandF added a commit to EnguerrandF/Projet_11 that referenced this issue May 17, 2023

correction bug OpenClassrooms-Student-Center#4, and deployed test

49c2ea5

Nathom78 mentioned this issue Jun 9, 2023

BUG: Clubs shouldn't be able to book more than 12 places per competition #3 #132

Closed

This was referenced Jan 29, 2024

BUG: Clubs should not be able to use more than their points allowed Mimi1706/Python_Testing#2

Closed

BUG: Clubs shouldn't be able to book more than 12 places per competition Mimi1706/Python_Testing#6

Merged

AlexBotswana added a commit to AlexBotswana/Python_Testing that referenced this issue Feb 21, 2024

Fix bug 12places max

f7fa180

Issue OpenClassrooms-Student-Center#4

AlexBotswana mentioned this issue Feb 21, 2024

Bug 12places max #216

Open

geo1310 added a commit to geo1310/Python_Testing that referenced this issue Apr 17, 2024

Resolve OpenClassrooms-Student-Center#4 : Add reserved_places in comp…

7c1d17e

…etitions.json

ClaireRuysschaert mentioned this issue Apr 19, 2024

Bug/fix: Clubs shouldn't be able to book more than 12 places per competition ClaireRuysschaert/P11_GUDLFT#3

Merged

br-imen linked a pull request May 31, 2024 that will close this issue

Bug/clubs should not be able to book more than 12 places per competition #227

Open

mumz0 mentioned this issue Aug 30, 2024

Bugfix/limit booking places mumz0/Python_Testing#4

Merged

LuuNa-JD mentioned this issue Nov 6, 2024

Fix : Limit booking to 12 places per competition #246

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BUG: Clubs shouldn't be able to book more than 12 places per competition #4

BUG: Clubs shouldn't be able to book more than 12 places per competition #4

dompatmore commented Jul 3, 2020 •

edited by HayVThom

Loading

BUG: Clubs shouldn't be able to book more than 12 places per competition #4

BUG: Clubs shouldn't be able to book more than 12 places per competition #4

Comments

dompatmore commented Jul 3, 2020 • edited by HayVThom Loading

dompatmore commented Jul 3, 2020 •

edited by HayVThom

Loading