Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reimplement unsaved warning #1191

Open
huss opened this issue Apr 3, 2024 · 2 comments
Open

reimplement unsaved warning #1191

huss opened this issue Apr 3, 2024 · 2 comments
Assignees
Labels
p-low-priority t-bug The issue is related to an aspect of the software which is incorrect
Milestone

Comments

@huss
Copy link
Member

huss commented Apr 3, 2024

Describe the bug

Before RTK, OED used UnsavedWarning (searching for this will show where) to let the admin know when they might lose a change because it was unsaved. This was commented out to add in later after the basic RTK conversion was done.

Expected behavior

These warning should be re-implemented and enabled in appropriate files.

OED currently does not, in general, use this in the new modal pages with cards. Thus, it is possible this will go away at some point. However, OED should decide if it should be used in some cases.

Additional context

None

@huss huss added t-bug The issue is related to an aspect of the software which is incorrect p-low-priority labels Apr 3, 2024
@huss huss added this to the 1.1 release milestone Apr 3, 2024
@huss huss moved this to Todo in Redux Toolkit Apr 3, 2024
@gyordong
Copy link
Contributor

gyordong commented Nov 6, 2024

Hi Steve, can @aduques and I work on this issue?

@huss
Copy link
Member Author

huss commented Nov 6, 2024

Hi Steve, can @aduques and I work on this issue?

@gyordong & @aduques You are welcome to work on this. I'm not sure how easy/hard it will be with the transition to using the Redux Toolkit. If it can be made to work we can discuss how it might be used with the modals. For example, would the warning pop up if the modal is closed (such as clicking off the modal) and there are unsaved changes? Please let me know if you need anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p-low-priority t-bug The issue is related to an aspect of the software which is incorrect
Projects
Status: Todo
Development

No branches or pull requests

2 participants