Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS: centralize styles, combine, limit usage #1203

Open
huss opened this issue Apr 4, 2024 · 5 comments
Open

CSS: centralize styles, combine, limit usage #1203

huss opened this issue Apr 4, 2024 · 5 comments
Assignees
Labels
i-good-first-issue This issue is probably a good starting point for people new to coding or the OED project. p-low-priority t-enhancement This issues tracks a potential improvement to the software
Milestone

Comments

@huss
Copy link
Member

huss commented Apr 4, 2024

Is your feature request related to a problem? Please describe.

There is a modest amount of CSS styling done on pages. Doing it in a consistent way is desired.

Describe the solution you'd like

The following would be used for CSS:

  1. When the same styling is used in multiple places then it is defined in one place and reused. For example, formInputStyle is defined in multiple places.
  2. There are similar but slightly different styles in places. Decide if it really is necessary to do this.
  3. Some styles may have minimal effect. As a rule, OED should only custom CSS when really needed.

A careful sweep of the code to final all CSS styles will be needed to decide which ones can be modified.

Describe alternatives you've considered

Leave as is

Additional context

None

@huss huss added t-enhancement This issues tracks a potential improvement to the software p-low-priority i-good-first-issue This issue is probably a good starting point for people new to coding or the OED project. labels Apr 4, 2024
@huss huss added this to the 1.x milestone Apr 4, 2024
@danielshid
Copy link
Contributor

I will be working on this issue.

@huss huss assigned huss and danielshid and unassigned huss Jul 30, 2024
@williamw04
Copy link
Contributor

I can work on this issue

@huss
Copy link
Member Author

huss commented Aug 21, 2024

@danielshid Are you working on this or is it okay for @williamw04 to do this issue? Thanks.

@danielshid danielshid removed their assignment Aug 26, 2024
@vladoleksiyenko
Copy link
Contributor

Hi, is this issue by any chance open? My team has been eyeing it as a potential issue to pick up. Please let me know, but don't assign it right away, as we'd like to discuss other issues. Thank you.

@huss
Copy link
Member Author

huss commented Nov 22, 2024

Hi, is this issue by any chance open? My team has been eyeing it as a potential issue to pick up. Please let me know, but don't assign it right away, as we'd like to discuss other issues. Thank you.

This issue is assigned and I believe that developer is actively working on the issue. @williamw04 can confirm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i-good-first-issue This issue is probably a good starting point for people new to coding or the OED project. p-low-priority t-enhancement This issues tracks a potential improvement to the software
Projects
None yet
Development

No branches or pull requests

4 participants