Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add libdiscon library to official docker image #2258

Open
cortadocodes opened this issue Jun 7, 2024 · 0 comments
Open

Comments

@cortadocodes
Copy link
Contributor

cortadocodes commented Jun 7, 2024

Is your feature request related to a problem? Please describe.

We'd like to add the ROSCO libdiscon.so library to the official docker at build time (i.e. when a new version is released).

Describe the solution you'd like

The latest, for example, 3 minor versions would be available in the /lib/rosco directory in the built image eg.:

  • rosco_2.9.0_libdiscon.so
  • rosco_2.8.0_libdiscon.so
  • rosco_2.7.0_libdiscon.so

Periodically, the build matrix in the GitHub workflow can be updated to include updated versions of ROSCO.

These can then be pointed to in the servodyn file.

Describe alternatives you've considered

We're currently building and copying the library into our openfast container at runtime:

apt-get update
apt-get install python3-pip git cmake ninja-build gfortran
git clone https://github.com/NREL/ROSCO.git@2.9.0
cd ROSCO/
pip install -e .
cp /ROSCO/rosco/lib/libdiscon.so /lib/rosco/rosco_2.9.0_libdiscon.so
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant