Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use subclasses and imports rather than vendoring protocols #4

Open
IAlibay opened this issue Feb 28, 2024 · 0 comments
Open

Use subclasses and imports rather than vendoring protocols #4

IAlibay opened this issue Feb 28, 2024 · 0 comments

Comments

@IAlibay
Copy link
Member

IAlibay commented Feb 28, 2024

Please see here: #1 (comment)

The protocols are still being worked on upstream and they are being designed to be subclassed. Vendoring here is only going to lead to extra work & headaches.

TLDR; I spent a lot of time making sure that you could minimally create subclasses of the AFE protocol which only changed things like how you parameterize things. The same thing is WIP for the MD and RFE protocols.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant