Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary of suggestions for improvements to the builder #24

Open
tpiperatgod opened this issue Nov 25, 2021 · 3 comments
Open

Summary of suggestions for improvements to the builder #24

tpiperatgod opened this issue Nov 25, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@tpiperatgod
Copy link
Member

As we mentioned in the readme, the builder project is based on gcp/buildpacks with some modifications to facilitate support for Chinese users and support for OpenFunction's functions-framework. gcp/buildpacks primarily serves GCP, so we may need to do more work on improving builder customization.

Of course, we are also considering rewriting a Builder project that will still follow the buildpacks lifecycle criteria (which drove us to find out more about the builder's improvement needs).

@tpiperatgod
Copy link
Member Author

Feature request

We need to enable builder to support custom configuration of source code repository addresses, dependency repository addresses, etc.

User case

This would make sense in the case of using a local(or private) repository.

@tpiperatgod tpiperatgod added the enhancement New feature or request label Nov 25, 2021
@tpiperatgod tpiperatgod pinned this issue Nov 25, 2021
@benjaminhuo
Copy link
Member

benjaminhuo commented Nov 26, 2021

As we mentioned in the readme, the builder project is based on gcp/buildpacks with some modifications to facilitate support for Chinese users and support for OpenFunction's functions-framework. gcp/buildpacks primarily serves GCP, so we may need to do more work on improving builder customization.

Of course, we are also considering rewriting a Builder project that will still follow the buildpacks lifecycle criteria (which drove us to find out more about the builder's improvement needs).

Agree, we should have our own builder and should have a better understanding of the buildpacks tech

@tpiperatgod
Copy link
Member Author

Feature request

Pass through the information (package name, version number, etc.) of functions-framework via environment variables.

User case

This will decouple the builder with the functions-framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

4 participants