Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate SimulationOutput #513

Open
nkrah opened this issue Oct 28, 2024 · 0 comments
Open

deprecate SimulationOutput #513

nkrah opened this issue Oct 28, 2024 · 0 comments

Comments

@nkrah
Copy link
Collaborator

nkrah commented Oct 28, 2024

There is actually no need anymore for the SimulationOutput class. It would be simpler to pass back the Simulation object from a subprocess and do all merging operations based on that. This would also pave the road for remote multiprocessing where the one Simulation object per process could be recreated from the json file.

Background: The SimulationOutput was necessary before the engines were restructured, before pickling was properly implemented, and before the actors were refactored. It has now actually become redundant. We might need to check if the sources need to be refactored into GateObjects first to fully avoid the SimulationOutput object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant