-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add to scan metadata and/or notes every time a user reviews a scan #104
Comments
So far we don't ever generate notes, to my knowledge. But in order to make the "bad" button available, a reviewer has to add characters to the note field, which then become the first note for that scan. If the previous reviewer left a note marking the image as good, that would be enough to enable the "bad" button too, which probably isn't the right behavior. |
Yeah, I'm concerned about this potential regression.
It's not too involved and we should move toward that longer term, but if we converted the column to something like a JSON list it might end up being more to maintain short term and more iteration than a quick fix on the note field. I lean toward quick-fixing the note field specifically for his use case and handling the more general export and adapter design in v2. How about this implementation:
One more note: Kilian indicated that for his use case he would like to see XNAT terms like "Usable" and "Questionable" instead of "Good" and "Bad". Below is a potential log, where first line is a note, second is a Good button press, third is Bad button press that required a rationale.
|
I like the note suggestion and concur that it is likely to be easier to add the note functionality than the metadata extra CSV column. |
Per Kilian/Jim on 4/28/21 meeting -
The text was updated successfully, but these errors were encountered: