Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config about tpm #364

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add config about tpm #364

wants to merge 3 commits into from

Conversation

guo21
Copy link

@guo21 guo21 commented Nov 13, 2017

Add some steps to config TPM.

@codecov-io
Copy link

codecov-io commented Nov 13, 2017

Codecov Report

Merging #364 into master will decrease coverage by 0.09%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #364     +/-   ##
=========================================
- Coverage   92.45%   92.35%   -0.1%     
=========================================
  Files          66       66             
  Lines       11175    11191     +16     
=========================================
+ Hits        10332    10336      +4     
- Misses        843      855     +12
Impacted Files Coverage Δ
kmip/services/server/config.py 92.72% <25%> (-7.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cb4c98...61f86dd. Read the comment docs.

@PeterHamilton
Copy link
Contributor

While this is a decent first stab at some config options for the TPM work, I think we should hold off on merging directly into master. Go ahead and put together a working, end-to-end prototype in your own forked repo. That way you can experiment and tweak things without needing my approval for your design. Once you have a solid prototype, we can step back and take a look at what it would require to merge into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants