-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change file monitoring for LCLS to support custom config files #429
Comments
Thx for the details. Since not changing this shouldn't break anything I'll file this under the 23.0.12 milestone to target for that release. |
An update: implementing this change also will not break anything - so it can be done anytime. |
Just a quick note that I think you need to change that same file to send all XML files to LCLS, instead of just |
Seems like we're not going to be able to get updates on the liberty plugin cfg via DidChangeWatchedFiles eclipse/lsp4e#547 |
Closing this since we did the biggest piece in #460. We still have a smaller effort remaining: #461 to be able to react dynamically to updates to the plugin cfg. For the time being the user will have to do some kind of restart...either of the IDE or dev mode. Would be nice to have doc but if we're going to fix anyway maybe it's not as much of a priority. |
To support custom config files, after OpenLiberty/liberty-language-server#212 goes in, the IDE client side needs to be changed to monitor the following to send to LCLS:
.env
and.properties
files - language support. Lines to change shown below:liberty-tools-eclipse/bundles/io.openliberty.tools.eclipse.lsp4e/plugin.xml
Lines 47 to 67 in 2fb4b6b
liberty-plugin-config.xml
- watch file for changes.LSP protocol
workspace/didChangeWatchedFiles
possibly not supported, as per Support forworkspace/didChangeWatchedFiles
eclipse/lsp4e#807Not changing it shouldn't break anything, but will not have support for custom config files.
Can model after OpenLiberty/liberty-tools-vscode#286
The text was updated successfully, but these errors were encountered: