Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change file monitoring for LCLS to support custom config files #429

Closed
evie-lau opened this issue Sep 6, 2023 · 5 comments
Closed

Change file monitoring for LCLS to support custom config files #429

evie-lau opened this issue Sep 6, 2023 · 5 comments
Milestone

Comments

@evie-lau
Copy link
Member

evie-lau commented Sep 6, 2023

To support custom config files, after OpenLiberty/liberty-language-server#212 goes in, the IDE client side needs to be changed to monitor the following to send to LCLS:

  • all .env and .properties files - language support. Lines to change shown below:

<extension
point="org.eclipse.core.contenttype.contentTypes">
<content-type
base-type="org.eclipse.core.runtime.text"
file-names="bootstrap.properties"
id="io.openliberty.tools.eclipse.org.liberty.tools.config.bootstrap-properties"
name="Liberty Server Bootstrap Properties"
priority="normal">
</content-type>
</extension>
<extension
point="org.eclipse.core.contenttype.contentTypes">
<content-type
base-type="org.eclipse.core.runtime.text"
file-names="server.env"
id="io.openliberty.tools.eclipse.org.liberty.tools.config.server-env"
name="Liberty Server Env Settings"
priority="normal">
</content-type>
</extension>

Not changing it shouldn't break anything, but will not have support for custom config files.

Can model after OpenLiberty/liberty-tools-vscode#286

@scottkurz
Copy link
Member

Thx for the details.

Since not changing this shouldn't break anything I'll file this under the 23.0.12 milestone to target for that release.

@scottkurz scottkurz added this to the 23.0.12 milestone Sep 7, 2023
@evie-lau
Copy link
Member Author

evie-lau commented Sep 7, 2023

An update: implementing this change also will not break anything - so it can be done anytime.

@evie-lau evie-lau changed the title Change file monitoring for LCLS Change file monitoring for LCLS to support custom config files Oct 4, 2023
@cherylking
Copy link
Member

Just a quick note that I think you need to change that same file to send all XML files to LCLS, instead of just server.xml. LCLS will then check for the server root element to decide if the file gets support.

@scottkurz
Copy link
Member

Seems like we're not going to be able to get updates on the liberty plugin cfg via DidChangeWatchedFiles eclipse/lsp4e#547

@scottkurz
Copy link
Member

Closing this since we did the biggest piece in #460.

We still have a smaller effort remaining: #461 to be able to react dynamically to updates to the plugin cfg. For the time being the user will have to do some kind of restart...either of the IDE or dev mode. Would be nice to have doc but if we're going to fix anyway maybe it's not as much of a priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants