Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom config dir/files support does not initialize on IDE startup or opening project #535

Closed
evie-lau opened this issue Oct 19, 2023 · 2 comments
Assignees
Labels
3 Estimated story points language client language server integration lsp4ij

Comments

@evie-lau
Copy link
Member

evie-lau commented Oct 19, 2023

Problem

Support for custom config dir/files doesn't work on IDE startup or opening a new project
Currently it only triggers when running mvn liberty:create or gradle libertyCreate, or if the liberty-plugin-config.xml file gets modified after opening the project in the IDE.

Cause

This is because our current version of lsp4ij does not support initializing LSP workspaces. intellij-quarkus has already added this support in a newer version of lsp4ij.

Solution

Either

  • Bring our version of lsp4ij up to date with intellij-quarkus to support workspaces.
  • Wait for the common lsp4ij component and switch over to that.

Note: these should also remove the need for the filewatcher introduced in #510, as there will be support for LSP's workspace/didChangeWatchedFiles

@turkeylurkey
Copy link
Member

The first init msg has

"workspaceFolders": [
    {
      "uri": "file:///Users/turk/demo/guide-getting-started/",
      "name": "guide-getting-started"
    }

turkeylurkey added a commit to turkeylurkey/liberty-tools-intellij that referenced this issue Jan 22, 2024
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
turkeylurkey added a commit that referenced this issue Jan 26, 2024
[#535] Remove the file watcher introduced in issue 510.
@turkeylurkey
Copy link
Member

Fixed by using the latest lsp4ij as tracked by #592.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 Estimated story points language client language server integration lsp4ij
Projects
Development

No branches or pull requests

3 participants