Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transform the Quick fixes related to ModifyModifiersProposal to implement the code action participant extension point. #543

Closed
vaisakhkannan opened this issue Oct 23, 2023 · 2 comments
Closed

Transform the Quick fixes related to ModifyModifiersProposal to implement the code action participant extension point. #543

vaisakhkannan opened this issue Oct 23, 2023 · 2 comments
Assignees
@vaisakhkannan
Labels
1 Estimated story points enhancement New feature or request language client language server integration

Comments

@vaisakhkannan
Copy link
Contributor

See the initial work completed here: #312.

In addition to refactoring the code, the code action participants will need to be added to the plugin.xml and the relevant Jakarta EE code action tests should be enabled.
@vaisakhkannan vaisakhkannan self-assigned this Oct 23, 2023
@TrevCraw TrevCraw added enhancement New feature or request language client language server integration labels Oct 26, 2023
vaisakhkannan added a commit to vaisakhkannan/liberty-tools-intellij that referenced this issue Nov 14, 2023
@vaisakhkannan
[OpenLiberty#543] Refactored Quick fixes related to ModifyModifiersPr…
b25bedc 
…oposal
@vaisakhkannan vaisakhkannan mentioned this issue Nov 15, 2023
Merged
@vaisakhkannan vaisakhkannan mentioned this issue Nov 27, 2023
Closed
vaisakhkannan added a commit to vaisakhkannan/liberty-tools-intellij that referenced this issue Dec 6, 2023
@vaisakhkannan
Merge branch 'code-action-unification-2' into OpenLiberty#543-ModifyM…
96bb82f 
…odifiersProposal-Quickfix
@TrevCraw TrevCraw added the 1 Estimated story points label Jan 16, 2024
@TrevCraw TrevCraw mentioned this issue Jan 16, 2024
Closed
@vaisakhkannan
Copy link
Contributor Author

vaisakhkannan commented Jan 18, 2024 •
edited
Loading

Screenshot 2024-01-18 at 6 40 19 PM

@mrglavas , When adding the missing codeAction tests in the ResourceClassConstructorTest.java file from the PR eclipse/lsp4jakarta#510, I noticed a difference in the title while running the tests. Can I update the title in the messages.properties file as follows?

Screenshot 2024-01-18 at 7 13 16 PM

vaisakhkannan added a commit that referenced this issue Jan 23, 2024
@vaisakhkannan
Merge pull request #579 from vaisakhkannan/#543-ModifyModifiersPropos…
ca59e35 
…al-Quickfix

Transform the Quick fixes related to ModifyModifiersProposal to implement the code action
@vaisakhkannan
Copy link
Contributor Author

PR #579 successfully merged, and I am closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vaisakhkannan vaisakhkannan

Labels
1 Estimated story points enhancement New feature or request language client language server integration
Projects
Open Liberty Developer Experience
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TrevCraw @vaisakhkannan