Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mvnCmd and gradleCmd should quote executable paths #337

Open
covener opened this issue Jul 21, 2024 · 0 comments
Open

mvnCmd and gradleCmd should quote executable paths #337

covener opened this issue Jul 21, 2024 · 0 comments

Comments

@covener
Copy link
Member

covener commented Jul 21, 2024

When I try to start a server from the Liberty Dashboard, there is a shell quoting problem running the maven within the extension:

covener@cov-osx2-2 httpclients-jssehelper % /Users/covener/Library/Application Support/Code/User/globalStorage/pleiades.java-extension-pack-jdk/maven/latest/bin/mvn io.openliberty.tools:liberty-maven-plugin:dev -f 
"/Users/covener/SRC/httpclients-jssehelper/pom.xml"
zsh: no such file or directory: /Users/covener/Library/Application

AFAIK there is nothing special about my vscode and my project is based on a recent guide.

IIUC devCommands.ts should either return a quoted path (when not returning the "mvn" or "gradle" verbatim) or the callers of mvnCmd/gradleCmd need to wrap the returned value similar to how the maven plugin does with the references you can find to this utility function: https://github.com/microsoft/vscode-maven/blob/2ab8f392f418c8e0fe2903387f2b0013a1c50e78/src/utils/mavenUtils.ts#L170

https://github.com/OpenLiberty/liberty-tools-vscode/blob/main/src/liberty/devCommands.ts#L112

export async function mvnCmd(pomPath: string): Promise<string> {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant