Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test reports can be in a new location #340

Open
TrevCraw opened this issue Aug 30, 2024 · 2 comments · May be fixed by #347
Open

Test reports can be in a new location #340

TrevCraw opened this issue Aug 30, 2024 · 2 comments · May be fixed by #347
Assignees
Labels
bug Something isn't working must-fix
Milestone

Comments

@TrevCraw
Copy link
Contributor

Refer to OpenLiberty/liberty-tools-intellij#934 from LTI.

With the recent updates to version 3.5.0 for the Maven Surefire Plugin and Maven Failsafe Plugin, test reports are created in a new location by default.

We need to update the code where we currently hardcode the old location: https://github.com/OpenLiberty/liberty-tools-vscode/blob/main/src/liberty/devCommands.ts#L493

The current proposal is to check both new and old report locations, starting with the new location first.

@TrevCraw TrevCraw added bug Something isn't working must-fix labels Aug 30, 2024
@TrevCraw TrevCraw added this to the Next milestone Oct 8, 2024
@JoshwinThomasIBM
Copy link
Contributor

JoshwinThomasIBM commented Oct 15, 2024

Code changes are completed and is in for review , PR #347

@JoshwinThomasIBM
Copy link
Contributor

JoshwinThomasIBM commented Oct 18, 2024

Now we have hardcoded the directories to check for the reports. With the upcoming surefire report plugin releases , if there is any change with the directories then we can add the directories to look for as a list or as a property and iterate over each of them to check the availability of the report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working must-fix
Projects
2 participants