Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SkeletonHelper static properties are not copied in generated models #65

Open
Alzathar opened this issue Feb 17, 2017 · 0 comments
Open

Comments

@Alzathar
Copy link
Member

Internally the method ma::body::SkeletonHelper::reconstruct copies object dynamic properties to the generated models. However, there is no equivalent for the static properties. In some case, some of the static properties are useful for the models. This is the case for the static property sex defined in ma::body::LyonWholeBodyModel. This property is needed by some BSiP generator. Before commit 6be2a8f it was not possible to use together the LBWM model and the Dumas-McConville-Young tables. The latter was looking for the sex property not available in the given models. As a quick fix it was decided to remove the static property. However this problem might happen again with other skeleton helper.

A rework of this part is needed. At least two propositions exist:

  • Implement a way to copy static properties
  • Use another mechanism than the properties to set helper configuration (i.e. calibration I/O)
@Alzathar Alzathar added the bug label Feb 17, 2017
@Alzathar Alzathar added this to the 1.0 milestone Feb 17, 2017
@Alzathar Alzathar self-assigned this Feb 17, 2017
@Alzathar Alzathar added this to TODO in Code Refactoring Feb 17, 2017
@Alzathar Alzathar added this to TODO in New ma::body module Feb 17, 2017
@Alzathar Alzathar modified the milestones: 0.8, 1.0 Feb 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant