Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise different errors based on the error code returned from the DP Library #413

Open
dibakch opened this issue Apr 21, 2022 · 0 comments
Open
Labels
Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor

Comments

@dibakch
Copy link
Contributor

dibakch commented Apr 21, 2022

Description

In the builder of algorithms or numerical mechanisms, the DP Library returns different error types, i.e., invalid argument, unimplemented, failed precondition, or internal errors. Based on those types, we should raise different exceptions in Python, too.

Are you interested in working on this improvement yourself?

  • No, I am not at the moment.

Additional Context

We would basically need to add a case statement based on the error code of the absl::StatusOr in the bindings.

@dibakch dibakch added the Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor label Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor
Projects
None yet
Development

No branches or pull requests

1 participant