Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract duplicate code in TensorFlowTensor & TensorFlowVariable #22

Open
jvmncs opened this issue Oct 11, 2019 · 1 comment
Open

Abstract duplicate code in TensorFlowTensor & TensorFlowVariable #22

jvmncs opened this issue Oct 11, 2019 · 1 comment
Labels
Good first issue 🎓 Perfect for beginners, welcome to OpenMined!

Comments

@jvmncs
Copy link
Contributor

jvmncs commented Oct 11, 2019

To do this properly, we'll want to move some of the code in TorchTensor from syft/frameworks/torch/tensors/interpreters/native.py into the AbstractTensor at syft/generic/tensor.py, and then call most of our code for these classes from the AbstractTensor base for TFTensor & TFVar.
@jvmncs jvmncs added the Good first issue 🎓 Perfect for beginners, welcome to OpenMined! label Oct 11, 2019
@jvmncs
Copy link
Contributor Author

jvmncs commented Oct 21, 2019

KerasObject seems to fulfill similar functions as well -- the class hierarchy here should probably be reviewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue 🎓 Perfect for beginners, welcome to OpenMined!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jvmncs