Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONBS doesn't recognize changes to tempo as an edit #433

Open
tehbigmac opened this issue Dec 6, 2023 · 0 comments
Open

ONBS doesn't recognize changes to tempo as an edit #433

tehbigmac opened this issue Dec 6, 2023 · 0 comments
Labels
C: Bug Something isn't working S: Resolved in next release This bugfix or suggestion has been applied to the code
Milestone

Comments

@tehbigmac
Copy link

Description
When changing the tempo on a saved file (meaning there is mo asterisk indicating unsaved changes after the file name in the title bar), ONBS doesn't add an asterisk to indicate the file's current state has not been saved, nor does it prompt the user to save changes before closing.

To Reproduce

  1. Open a preexisting file, or create and save a new one.
  2. Set the tempo to a different value than the current one.
  3. Notice how the asterisk does not appear next to the file name.
  4. Additionally, close the program and observe how no "save changes before closing" prompt appears.

Expected behavior
When the tempo of a saved song is changed, it should prompt the program to recognize it as an unsaved file, just as if an edit was made to the notes themselves.

Additional context
ONBS recognizes modified song properties as unsaved changes to a song, so it's odd that tempo isn't recognized as such.

@Bentroen Bentroen added the C: Bug Something isn't working label Mar 31, 2024
@Bentroen Bentroen modified the milestones: v3.x, v3.10.1 Mar 31, 2024
Bentroen added a commit that referenced this issue Apr 4, 2024
Affects the following instances:

- making tempo compatible with schematics/data packs via Compatibility window
- clicking 'OK' in the tempo tapper window
- selecting a tempo option from the tempo box context menu
- confirming a valid change typed to the tempo box

Fixes #433
@Bentroen Bentroen added the S: Resolved in next release This bugfix or suggestion has been applied to the code label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Bug Something isn't working S: Resolved in next release This bugfix or suggestion has been applied to the code
Projects
None yet
Development

No branches or pull requests

2 participants