Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot print or export to PDF as vector graphics #1914

Closed
jjojala opened this issue Mar 15, 2021 · 5 comments · Fixed by #1915
Closed

Cannot print or export to PDF as vector graphics #1914

jjojala opened this issue Mar 15, 2021 · 5 comments · Fixed by #1915

Comments

@jjojala
Copy link
Contributor

jjojala commented Mar 15, 2021

Steps to reproduce

  1. Open "forest sample.omap" (part of the distribution)
  2. From the menu: File->Export as...->PDF
  3. PDF export dialog appears for setting export options

Actual behaviour

Mode "Raster graphics" is on. Mode "Vector graphis" is disabled and cannot be chosen. PDF is generated in raster graphics mode.

Expected behaviour

Mode "Vector graphics" should be available (as it used to be in 0.9.4).

Configuration

Mapper Version: 0.9.5
Operating System: Windows 10 Pro

@jjojala
Copy link
Contributor Author

jjojala commented Mar 15, 2021

My C++ skills are already a bit rusty after so many years, but does it seem be in
https://github.com/OpenOrienteering/mapper/blob/v0.9.5/src/gui/print_widget.cpp#L658
that invokes method kmzTarget() in https://github.com/OpenOrienteering/mapper/blob/v0.9.5/src/core/map_printer.cpp#L401
that returns always non-NULL, i.e. TRUE.

@dl3sdo
Copy link
Member

dl3sdo commented Mar 15, 2021

@jjojala: Yes, I agree.
bool is_raster_target = target == MapPrinter::imageTarget() || target == MapPrinter::kmzTarget();
does solve the issue and offers Vector graphics again.

@dg0yt dg0yt added this to the v0.9.6 milestone Mar 16, 2021
dg0yt pushed a commit that referenced this issue Mar 16, 2021
Resolves GH-1914 (PDF export as vector not possible).
Co-authored-by: Kai Pastor <dg0yt@darc.de>
@dg0yt dg0yt pinned this issue Mar 16, 2021
@dg0yt dg0yt changed the title Cannot export map as vector graphics PDF Cannot print or export to PDF as vector graphics Mar 26, 2021
@ghost
Copy link

ghost commented Jul 19, 2021

@dg0yt, please, update master and unstable builds on OBS.

@ghost
Copy link

ghost commented Jan 5, 2022

JFTR, @jjojala, latest unstable 0.9.20211224 builds already include fix for this issue — vector PDF works as expected now!

Till next release (0.9.6 or 1.0.0) would be released, You may install and use unstable builds of OpenOrienteering Mapper app under Linux:

Info for Windows, Mac & Android users

Note
Now nightly builds (with fixed PDF export) for all platforms also available via Azure DevOps CI/CD:

Go to latest successful commit pipeline (with "green check-mark") and follow the next guide on how to get artifact.

Warning
Azur CI/CD build for Linux is targeted for Ubuntu 18.04 and DEB has no dependency list info.

For example, here is actual latest successful pipeline:

And here are its artifacts (ZIP'ed binary builds):

Highlight needed binary build row — you would see ("vertical three dots") on the right end of highlighted row:

Screenshot from 2022-06-02 00-39-49

Click on ("vertical three dots") & in drop-down menu click on Download artifacts:

Screenshot from 2022-06-02 00-41-57

@app4soft
Copy link

app4soft commented Dec 2, 2023

There was no release & unstable builds for a while and existing builds on OBS are not suitable for latest Debian 12.

@dg0yt, Could be fresh unstable/master compiled and packaged, including for Debian 12, on OBS?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants