Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Map color import - give the user option to place the colors at the top or the bottom #2176

Open
lpechacek opened this issue Aug 3, 2023 · 3 comments

Comments

@lpechacek
Copy link
Member

Steps to reproduce

  1. Import symbols with new colors.

Actual behaviour

Mapper places all the new colors at the bottom of the list.

Expected behaviour

It would be great if there was an option to place them at the top of the list.

Configuration

Mapper Version: 0.9.5
Operating System: all desktop

@dg0yt
Copy link
Member

dg0yt commented Aug 3, 2023

Doesn't Mapper already try to merge color lists, so that good results are achieved if the the colors are aligned before doing the import?
If yes, the requested change would need to be implemented with great care, to not degrade existing behaviour.

@lpechacek lpechacek changed the title Enhancement: Map color import - give the user option to place the colors at the top of the bottom Enhancement: Map color import - give the user option to place the colors at the top or the bottom Aug 4, 2023
@lpechacek
Copy link
Member Author

Doesn't Mapper already try to merge color lists, so that good results are achieved if the the colors are aligned before doing the import?

Good question. Yes, Mapper does a great job in maintaining the color order and merging color tables.

However, if the colors are not "aligned", i.e. the new color set has no link to the existing ones and all the colors are new, the new colors are placed at the bottom. In this particular situation (all colors new, no merging), I don't see what defines whether the new colors should go to the top or the bottom of the table.

Screencast.from.2023-08-04.15-57-47.webm

The use case is an import of helper drawing symbols that should displayed over the regular symbols. The helper symbols are removed when the map is finalized.

@eolmapper
Copy link

eolmapper commented Sep 19, 2023

A smart solution would be to have a dialog box when importing new objects:
"Mapper as detect new colors from imported objects"
Option1: place the news colors at the top of the table
Option 2: place the news colors at the bottom of the table
Option 3: Associate colors with existing colors
association table as for symbols like this
table exemple

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants