Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui-trackoccupancydiagram: setup sub-repo #714

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

Yohh
Copy link
Contributor

@Yohh Yohh commented Nov 19, 2024

the story is set in storybook/stories in order to anticipate the future migration of all stories in there.

close #703

@Yohh Yohh requested a review from a team as a code owner November 19, 2024 14:17
@Yohh Yohh force-pushed the yoh/setup-trackoccupancydiagram-module branch from 5bfbfaa to e641695 Compare November 19, 2024 14:52
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a small review with some suggestions. But the current setup is a good starting point.

ui-trackoccupancydiagram/rollup.config.js Outdated Show resolved Hide resolved
Copy link
Contributor

@RomainValls RomainValls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested, thanks 👍

@Yohh Yohh requested a review from kmer2016 November 20, 2024 10:22
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Co-authored-by: Uriel-Sautron <uriel.sautron@gmail.com>
Signed-off-by: Yohh <durandyohan@zaclys.net>
@Yohh Yohh force-pushed the yoh/setup-trackoccupancydiagram-module branch from e9024d8 to 0863517 Compare November 20, 2024 13:31
@Yohh Yohh added this pull request to the merge queue Nov 20, 2024
Merged via the queue into dev with commit 3ffe206 Nov 20, 2024
6 checks passed
@Yohh Yohh deleted the yoh/setup-trackoccupancydiagram-module branch November 20, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trackoccupancydiagram: setup sub-repo
3 participants