fixes

OpenRailAssociation · Oct 28, 2024 · 0457ced · 0457ced
1 parent fe6a292
commit 0457ced
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/front/src/common/authorization/components/ProtectedRoute.tsx b/front/src/common/authorization/components/ProtectedRoute.tsx
@@ -1,9 +1,11 @@
 import { Navigate } from 'react-router-dom';
 
+import type { BuiltinRole } from 'common/api/osrdEditoastApi';
+
 import useUserRoleCheck from '../hooks/useUserRoleCheck';
 
 type ProtectedRouteProps = {
-  allowedRoles: string[];
+  allowedRoles: BuiltinRole[];
   children: React.ReactNode;
 };
 

diff --git a/front/src/common/authorization/hooks/useUserRoleCheck.ts b/front/src/common/authorization/hooks/useUserRoleCheck.ts
@@ -10,8 +10,7 @@ const useUserRoleCheck = (allowedRoles: BuiltinRole[]) => {
   if (allowedRoles.length === 0 || isSuperUser) {
     return true;
   }
-
-  return allowedRoles.every((role) => userRoles.includes(role));
+  return allowedRoles.some((role) => userRoles.includes(role));
 };
 
 export default useUserRoleCheck;